eliminated deprecatd NOSONAR cpp:S4963 #verification #sonar #docs

docs/examples/platform/linux/epoll_single_threaded_executor.hpp

@@ -158,9 +158,7 @@ class EpollSingleThreadedExecutor final : public libcyphal::platform::SingleThre
     using Base = SingleThreadedExecutor;
     using Self = EpollSingleThreadedExecutor;
 
-    /// No Sonar cpp:S4963 b/c `AwaitableNode` supports move operation.
-    ///
-    class AwaitableNode final : public CallbackNode  // NOSONAR cpp:S4963
+    class AwaitableNode final : public CallbackNode
     {
     public:
         AwaitableNode(Self& executor, Callback::Function&& function)

docs/examples/platform/posix/posix_single_threaded_executor.hpp

@@ -207,9 +207,7 @@ class PollSingleThreadedExecutor final : public libcyphal::platform::SingleThrea
         DoubleLinkedNode* next_node;
     };
 
-    /// No Sonar cpp:S4963 b/c `AwaitableNode` supports move operation.
-    ///
-    class AwaitableNode final : public CallbackNode, public DoubleLinkedNode  // NOSONAR cpp:S4963
+    class AwaitableNode final : public CallbackNode, public DoubleLinkedNode
     {
     public:
         AwaitableNode(Self& executor, Callback::Function&& function, DoubleLinkedNode& origin_node)

include/libcyphal/application/node/get_info_provider.hpp

@@ -32,10 +32,7 @@ namespace node
 ///
 /// Internally, it uses the 'GetInfo' service server to handle incoming requests.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here (namely capturing of `this` in the request callback).
-///
-class GetInfoProvider final  // NOSONAR cpp:S4963
+class GetInfoProvider final
 {
     using Service = uavcan::node::GetInfo_1_0;
 

include/libcyphal/application/node/heartbeat_producer.hpp

@@ -34,10 +34,7 @@ namespace node
 ///
 /// Internally, it uses the 'Heartbeat' message publisher to periodically publish heartbeat messages.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here (namely capturing of `this` in the periodic callback).
-///
-class HeartbeatProducer final  // NOSONAR cpp:S4963
+class HeartbeatProducer final
 {
 public:
     /// @brief Defines the message type for the Heartbeat.

include/libcyphal/application/node/registry_provider.hpp

@@ -30,10 +30,7 @@ namespace node
 ///
 /// Internally, it uses the registry 'List' and 'Access' service servers to handle incoming requests.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here (namely capturing of `this` in the request callback).
-///
-class RegistryProvider final  // NOSONAR cpp:S4963
+class RegistryProvider final
 {
     using ListService   = uavcan::_register::List_1_0;
     using AccessService = uavcan::_register::Access_1_0;

include/libcyphal/application/registry/register.hpp

@@ -51,9 +51,7 @@ enum class SetError : std::uint8_t
 
 /// Defines interface for a register.
 ///
-/// NOSONAR cpp:S4963 for below `class IRegister` - protected destructor is necessary.
-///
-class IRegister : public cavl::Node<IRegister>  // NOSONAR cpp:S4963
+class IRegister : public cavl::Node<IRegister>
 {
     // 1AD1885B-954B-48CF-BAC4-FA0A251D3FC0
     // clang-format off

include/libcyphal/common/cavl/cavl.hpp

@@ -58,10 +58,9 @@ class Tree;
 /// The size of this type is 4x pointer size (16 bytes on a 32-bit platform).
 ///
 /// No Sonar cpp:S1448 b/c this is the main node entity without public members - maintainability is not a concern here.
-/// No Sonar cpp:S4963 b/c `Node` supports move operation.
 ///
 template <typename Derived>
-class Node  // NOSONAR cpp:S1448 cpp:S4963
+class Node  // NOSONAR cpp:S1448
 {
     // Polyfill for C++17's std::invoke_result_t.
     template <typename F, typename... Args>
@@ -954,8 +953,7 @@ class Tree final  // NOSONAR cpp:S3624
     /// the same call stack) we may occasionally fail to detect a bona fide case of a race condition, but this is
     /// acceptable because the purpose of this feature is to provide a mere best-effort data race detection.
     ///
-    /// No Sonar cpp:S4963 b/c of the RAII pattern.
-    class TraversalIndicatorUpdater final  // NOSONAR cpp:S4963
+    class TraversalIndicatorUpdater final
     {
     public:
         explicit TraversalIndicatorUpdater(const Tree& sup) noexcept
@@ -994,7 +992,7 @@ class Tree final  // NOSONAR cpp:S3624
     // including the root node whos `up` points to this origin node (see `isRoot` method).
     Node<Derived> origin_node_{};
 
-    // No Sonar cpp:S4963 b/c of implicit modification by the `TraversalIndicatorUpdater` RAII class,
+    // No Sonar cpp:S3687 b/c of implicit modification by the `TraversalIndicatorUpdater` RAII class,
     // even for `const` instance of the `Tree` class (hence the `mutable volatile` keywords).
     mutable volatile bool traversal_in_progress_ = false;  // NOSONAR cpp:S3687
 };

include/libcyphal/platform/single_threaded_executor.hpp

@@ -111,9 +111,7 @@ class SingleThreadedExecutor : public IExecutor
     }
 
 protected:
-    /// No Sonar cpp:S4963 b/c `CallbackNode` supports move operation.
-    ///
-    class CallbackNode : public cavl::Node<CallbackNode>, public Callback::Interface  // NOSONAR cpp:S4963
+    class CallbackNode : public cavl::Node<CallbackNode>, public Callback::Interface
     {
     public:
         CallbackNode(SingleThreadedExecutor& executor, Callback::Function&& function)

include/libcyphal/presentation/client_impl.hpp

@@ -79,10 +79,7 @@ class SharedClient : public cavl::Node<SharedClient>, public SharedObject
 
     };  // TimeoutNode
 
-    /// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-    /// b/c we do directly handle resources here.
-    ///
-    class CallbackNode : public Node<CallbackNode>, public TimeoutNode  // NOSONAR cpp:S4963
+    class CallbackNode : public Node<CallbackNode>, public TimeoutNode
     {
     public:
         CallbackNode(const CallbackNode&)                = delete;

include/libcyphal/presentation/presentation.hpp

@@ -95,12 +95,9 @@ struct IsFixedPortIdMessageTrait<T, true>
 /// @brief Defines the main presentation layer class.
 ///
 /// Instance of this class is supposed to be created once per transport instance (or even per application).
-/// Main purpose of the presentation object is to create publishers, subscribers, and RPC clients and servers.
+/// The main purpose of the presentation object is to create publishers, subscribers, and RPC clients and servers.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here.
-///
-class Presentation final : private detail::IPresentationDelegate  // NOSONAR cpp:S4963
+class Presentation final : private detail::IPresentationDelegate
 {
 public:
     /// @brief Defines failure type of various `make...` methods of the presentation layer.

include/libcyphal/presentation/publisher.hpp

@@ -33,10 +33,7 @@ namespace detail
 
 /// @brief Defines internal base class for any concrete (final) message publisher.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here.
-///
-class PublisherBase  // NOSONAR cpp:S4963
+class PublisherBase
 {
 public:
     /// @brief Defines failure type for a base publisher operations.

include/libcyphal/presentation/response_promise.hpp

@@ -64,11 +64,8 @@ using ResponsePromiseFailure = libcyphal::detail::AppendType<  //
 ///                         either a deserializable type (like a Nunavut tool generated service response struct),
 ///                         or `transport::ScatteredBuffer` for raw bytes (aka untyped) responses.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here (like `client_impl_` retain/release etc.).
-///
 template <typename ResponsePayload, typename Failure>
-class ResponsePromiseBase : public detail::SharedClient::CallbackNode  // NOSONAR cpp:S4963
+class ResponsePromiseBase : public detail::SharedClient::CallbackNode
 {
 public:
     /// @brief Defines successful response and its metadata.

include/libcyphal/presentation/server.hpp

@@ -41,10 +41,7 @@ namespace detail
 
 /// @brief Defines internal base class for any concrete (final) RPC server.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here.
-///
-class ServerBase : ServerImpl::Callback  // NOSONAR cpp:S4963
+class ServerBase : ServerImpl::Callback
 {
 public:
     /// @brief Defines failure type for a base server operations.

include/libcyphal/presentation/subscriber.hpp

@@ -31,10 +31,7 @@ namespace detail
 
 /// @brief Defines internal base class for any concrete (final) message subscriber.
 ///
-/// No Sonar cpp:S4963 'The "Rule-of-Zero" should be followed'
-/// b/c we do directly handle resources here.
-///
-class SubscriberBase : public SubscriberImpl::CallbackNode  // NOSONAR cpp:S4963
+class SubscriberBase : public SubscriberImpl::CallbackNode
 {
 public:
     /// @brief Defines failure type for a base subscriber operations.

include/libcyphal/transport/can/can_transport_impl.hpp

@@ -51,10 +51,7 @@ namespace detail
 
 /// @brief Represents final implementation class of the CAN transport.
 ///
-/// NOSONAR cpp:S4963 for below `class TransportImpl` - we do directly handle resources here;
-/// namely: in destructor we have to flush TX queues (otherwise there will be memory leaks).
-///
-class TransportImpl final : private TransportDelegate, public ICanTransport  // NOSONAR cpp:S4963
+class TransportImpl final : private TransportDelegate, public ICanTransport
 {
     /// @brief Defines private specification for making interface unique ptr.
     ///

include/libcyphal/transport/can/delegate.hpp

@@ -44,9 +44,7 @@ class TransportDelegate
 public:
     /// @brief RAII class to manage memory allocated by Canard library.
     ///
-    /// NOSONAR cpp:S4963 for below `class CanardMemory` - we do directly handle resources here.
-    ///
-    class CanardMemory final : public ScatteredBuffer::IStorage  // NOSONAR cpp:S4963
+    class CanardMemory final : public ScatteredBuffer::IStorage
     {
     public:
         CanardMemory(TransportDelegate& delegate,

include/libcyphal/transport/can/msg_rx_session.hpp

@@ -38,10 +38,7 @@ namespace detail
 
 /// @brief A class to represent a message subscriber RX session.
 ///
-/// NOSONAR cpp:S4963 for below `class MessageRxSession` - we do directly handle resources here;
-/// namely: in destructor we have to unsubscribe, as well as let transport delegate to know this fact.
-///
-class MessageRxSession final : IRxSessionDelegate, public IMessageRxSession  // NOSONAR cpp:S4963
+class MessageRxSession final : IRxSessionDelegate, public IMessageRxSession
 {
     /// @brief Defines private specification for making interface unique ptr.
     ///

include/libcyphal/transport/can/svc_rx_sessions.hpp

@@ -44,11 +44,8 @@ namespace detail
 /// @tparam TransferKind Kind of the service transfer.
 ///                      Could be either `CanardTransferKindRequest` or `CanardTransferKindResponse`.
 ///
-/// NOSONAR cpp:S4963 for below `class SvcRxSession` - we do directly handle resources here;
-/// namely: in destructor we have to unsubscribe, as well as let transport delegate to know this fact.
-///
 template <typename Interface_, typename Params, CanardTransferKind TransferKind>
-class SvcRxSession final : IRxSessionDelegate, public Interface_  // NOSONAR cpp:S4963
+class SvcRxSession final : IRxSessionDelegate, public Interface_
 {
     /// @brief Defines private specification for making interface unique ptr.
     ///

include/libcyphal/transport/contiguous_payload.hpp

@@ -36,7 +36,7 @@ namespace detail
 /// Probably could be deleted when libcanard will start support fragmented payloads (at `canardTxPush`).
 /// See https://github.com/OpenCyphal/libcanard/issues/223
 ///
-class ContiguousPayload final  // NOSONAR : cpp:S4963 - we do directly handle resources here.
+class ContiguousPayload final
 {
 public:
     ContiguousPayload(cetl::pmr::memory_resource& mr, const PayloadFragments payload_fragments)

include/libcyphal/transport/media_payload.hpp

@@ -23,7 +23,7 @@ namespace transport
 /// In use to pass payload data between the transport layer and its media.
 /// It also manages memory ownership of the allocated payload buffer.
 ///
-class MediaPayload final  // NOSONAR : cpp:S4963 - we do directly handle resources here.
+class MediaPayload final
 {
 public:
     /// Constructs a new empty payload.

include/libcyphal/transport/scattered_buffer.hpp

@@ -26,7 +26,7 @@ namespace transport
 /// The buffer is movable but not copyable because copying the contents of a buffer is considered wasteful.
 /// The buffer behaves as if it's empty if the underlying implementation is moved away.
 ///
-class ScatteredBuffer final  // NOSONAR : cpp:S4963 - we do directly handle resources here.
+class ScatteredBuffer final
 {
 public:
     /// @brief Defines maximum size (aka footprint) of the storage variant.

include/libcyphal/transport/udp/delegate.hpp

@@ -78,9 +78,7 @@ class TransportDelegate
 public:
     /// @brief RAII class to manage memory allocated by Udpard library.
     ///
-    /// NOSONAR cpp:S4963 for below `class UdpardMemory` - we do directly handle resources here.
-    ///
-    class UdpardMemory final : public ScatteredBuffer::IStorage  // NOSONAR cpp:S4963
+    class UdpardMemory final : public ScatteredBuffer::IStorage
     {
     public:
         UdpardMemory(TransportDelegate& delegate, UdpardRxTransfer& transfer)

include/libcyphal/transport/udp/msg_rx_session.hpp

@@ -38,10 +38,7 @@ namespace detail
 
 /// @brief A class to represent a message subscriber RX session.
 ///
-/// NOSONAR cpp:S4963 for below `class MessageRxSession` - we do directly handle resources here;
-/// namely: in destructor we have to unsubscribe, as well as let transport delegate to know this fact.
-///
-class MessageRxSession final : IMsgRxSessionDelegate, public IMessageRxSession  // NOSONAR cpp:S4963
+class MessageRxSession final : IMsgRxSessionDelegate, public IMessageRxSession
 {
     /// @brief Defines private specification for making interface unique ptr.
     ///

include/libcyphal/transport/udp/session_tree.hpp

@@ -46,10 +46,8 @@ struct SocketState
 
 /// @brief Defines a tree of sessions for the UDP transport.
 ///
-/// No Sonar cpp:S4963 b/c we do directly handle resources here.
-///
 template <typename Node>
-class SessionTree final  // NOSONAR cpp:S4963
+class SessionTree final
 {
 public:
     using NodeRef = typename Node::ReferenceWrapper;

include/libcyphal/transport/udp/svc_rx_sessions.hpp

@@ -42,11 +42,8 @@ namespace detail
 /// @tparam Params Type of the session parameters.
 ///                Could be either `RequestRxParams` or `ResponseRxParams`.
 ///
-/// NOSONAR cpp:S4963 for below `class SvcRxSession` - we do directly handle resources here;
-/// namely: in destructor we have to unsubscribe, as well as let transport delegate to know this fact.
-///
 template <typename Interface_, typename Params, typename SessionEvent, bool IsRequest>
-class SvcRxSession final : IRxSessionDelegate, public Interface_  // NOSONAR cpp:S4963
+class SvcRxSession final : IRxSessionDelegate, public Interface_
 {
     /// @brief Defines private specification for making interface unique ptr.
     ///

include/libcyphal/transport/udp/udp_transport_impl.hpp

@@ -54,10 +54,7 @@ namespace detail
 
 /// @brief Represents final implementation class of the UDP transport.
 ///
-/// NOSONAR cpp:S4963 for below `class TransportImpl` - we do directly handle resources here;
-/// namely: in destructor we have to flush TX queues (otherwise there will be memory leaks).
-///
-class TransportImpl final : private TransportDelegate, public IUdpTransport  // NOSONAR cpp:S4963
+class TransportImpl final : private TransportDelegate, public IUdpTransport
 {
     /// @brief Defines private specification for making interface unique ptr.
     ///

test/unittest/virtual_time_scheduler.hpp

@@ -113,9 +113,7 @@ class VirtualTimeScheduler final : public platform::SingleThreadedExecutor
     using Self = VirtualTimeScheduler;
     using Base = SingleThreadedExecutor;
 
-    /// No Sonar cpp:S4963 b/c `AwaitableNode` supports move operation.
-    ///
-    class NamedCallbackNode final : public CallbackNode  // NOSONAR cpp:S4963
+    class NamedCallbackNode final : public CallbackNode
     {
     public:
         NamedCallbackNode(Self& executor, Callback::Function&& function, std::string name)