Use canardTxPoll; MediaPayload::Ownership
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new `IMedia::getTxMemoryResource` method. - Media implementations (at examples) now have their own TX memory resource. - Addopted recent v4 canard api changes. - each `canardTxInit` now initialized with media TX memory resource - addressed "// TODO: Remove this workaround when the issue is resolved." - canard memory management now has de-allocation amount parameter. - Extended all transport related unit tests to verify that TX pipeline uses its dedicated memory resource.
- Introduced `libcyphal::transport::MediaPayload` - in use to pass payload data between the transport layer and its media. - Use lates latest Canard v4 api
- latest canard v4 - latest udpard v2
…sponses, and PMR otherwise #verification #sonar #docs
# Conflicts: # include/libcyphal/transport/media_payload.hpp
serges147
commented
Dec 9, 2024
| namespace libcyphal | ||
| { | ||
| namespace common | ||
| { |
There was a problem hiding this comment.
Renamed for...
- to be consistent with
libcyphal/common/cavl/...folder structure - to minimize possible conflict if some project already has it's own CAVL copy (and not necessarily the same version)
serges147
commented
Dec 9, 2024
| @@ -788,7 +792,7 @@ class Tree final // NOSONAR cpp:S3624 | |||
| { | |||
| public: | |||
| /// Helper alias of the compatible node type. | |||
| using NodeType = ::cavl::Node<Derived>; | |||
| using NodeType = Node<Derived>; | |||
There was a problem hiding this comment.
already in upstream
serges147
commented
Dec 9, 2024
| @@ -998,5 +1002,7 @@ class Tree final // NOSONAR cpp:S3624 | |||
| }; | |||
|
|
|||
| } // namespace cavl | |||
| } // namespace common | |||
| } // namespace libcyphal | |||
There was a problem hiding this comment.
upstream stay as before - just ::cavl:: ...
pavel-kirienko
approved these changes
Dec 10, 2024
# Conflicts: # include/libcyphal/application/registry/register.hpp # include/libcyphal/platform/single_threaded_executor.hpp
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.