Fixed CAN transport media TX callback lifetime. #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifically verify TX media callback lifetime
serges147
commented
Feb 6, 2025
| // There was nothing successfully polled, | ||
| // AND won't be in the (near) future (b/c queue is empty), | ||
| // so we are done with this TX media - no more callbacks for now (until brand new TX transfer). | ||
| media.tx_callback().reset(); |
There was a problem hiding this comment.
Such .reset was lost after recent refactoring (to use new canardTxPoll api).
serges147
commented
Feb 6, 2025
| // There is nothing to send anymore, so we are done with this media TX socket - no more callbacks for now. | ||
| // There was nothing successfully sent (otherwise we would have `return`-ed earlier), | ||
| // AND won't be in the (near) future (b/c queue is empty), | ||
| // so we are done with this TX media - no more callbacks for now (until brand new TX transfer). | ||
| media.txSocketState().callback.reset(); |
There was a problem hiding this comment.
This important line now under unit tests - previously, you could comment it and unit tests would be still green. Not anymore.
|
pavel-kirienko
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #438: