Skip to content

Commit

Permalink
Enhance Parsing Response debug output
Browse files Browse the repository at this point in the history
More generic catch block for more detailed channel assignment errors. E.g. the original code is not able to catch the following kind of errors:
[modbus1 ] ERROR [dbus.api.task.AbstractReadTask] Parsing Response failed. IllegalArgumentException: Unable to set value [-4395165653183430656] for Channel [battery0/ChrW]: Cannot convert. Long [-4395165653183430656] is not fitting in Integer range.

This kind of messages would have been very helpful for detecting channel mapping errors, but it is not catched by OpenemsException
  • Loading branch information
clehne authored and DerStoecki committed Nov 20, 2024
1 parent 6f227ca commit 47542c5
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public ExecuteState execute(AbstractModbusBridge bridge) {

return ExecuteState.OK;

} catch (OpenemsException e1) {
} catch (Exception e1) {
logError(this.log, e1, "Parsing Response failed.");
throw e1;
}
Expand Down

0 comments on commit 47542c5

Please sign in to comment.