New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PACKED macro to SOEM_PACKED to avoid collision with fmtlib #835

Open

rtzoeller wants to merge 1 commit into OpenEtherCATsociety:master from rtzoeller:renamed-PACKED-macro

rtzoeller commented Jul 11, 2024

There is an unfortunate collision between SOEM and fmtlib, where SOEM's definition of a PACKED macro collides with a template parameter in fmtlib.

This causes some rather inscrutable compile errors, and isn't handled by the existing #ifndef check as fmtlib's usage is not a macro.


          Rename PACKED macro to SOEM_PACKED to avoid collision with fmtlib

1c649ad

There is an unfortunate collision between SOEM and [fmtlib](https://github.com/fmtlib/fmt), where SOEM's definition of a `PACKED` macro collides with a [template parameter in fmtlib](https://github.com/fmtlib/fmt/blob/92cdbbae06fe43f87a6c59eb1d623bb5abc8405d/include/fmt/base.h#L1649).

This causes some rather inscrutable compile errors, and isn't handled by the existing `#ifndef` check as fmtlib's usage is not a macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet