Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable indexer interval #11

Merged
merged 4 commits into from
Jan 29, 2024
Merged

configurable indexer interval #11

merged 4 commits into from
Jan 29, 2024

Conversation

haardikk21
Copy link
Contributor

Cannot be merged until #10 is merged

  • configurable indexer interval for background syncs

@haardikk21 haardikk21 requested a review from avichalp January 23, 2024 03:51
@haardikk21 haardikk21 marked this pull request as draft January 23, 2024 03:52
@haardikk21 haardikk21 marked this pull request as ready for review January 29, 2024 15:09
avichalp
avichalp approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@avichalp avichalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

slight nitpick but no strong opinion on this. maybe index_interval is a better name than indexer_interval_in_secs just because it is shorter and you could add a comment saying that the value is in seconds if needed.

@haardikk21 haardikk21 merged commit 5604b6e into main Jan 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avichalp avichalp avichalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haardikk21 @avichalp