Fixed a bug where control rates of polynomial controls were not correct in simulation. #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect under explicit shooting due to t_duration not being properly connected to the integration
…s and solution results dont have the same variables when building the timeseries report.
kaushikponnapalli
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The calculation of control rates in explicit shooting requires the input
t_durationwhen polynomial controls are used, but this variable was not correctly connected.Changed the control rate test into a number of subtests to reduce the amount of code required.
Added extra information when the bokeh timeseries refuses to build, but after these changes I no longer can reproduce #1132.
This has been addressed and a fix put in place.
Related Issues
Backwards incompatibilities
None
New Dependencies
None