Simplified modelChanged code

repository/OpenPonk-BPMN-Validation/OPBPMNValidationController.class.st

@@ -20,7 +20,7 @@ OPBPMNValidationController >> getValidations [
 
 	^ (self packageOrganizer packageNamed: 'OpenPonk-BPMN-Validation')
 		  definedClasses select: [ :class |
-		  class tags asSet includes: 'Validation-Classes' ]
+		  class packageTag name = 'Validation-Classes' ]
 ]
 
 { #category : 'as yet unclassified' }

repository/OpenPonk-BPMN-Validation/OPBPMNValidationControllerTest.class.st

@@ -23,13 +23,17 @@ OPBPMNValidationControllerTest >> testGetValidatedObjects [
 
 { #category : 'tests' }
 OPBPMNValidationControllerTest >> testGetValidations [
+
 	| controller validations |
 	controller := OPBPMNValidationController new.
 	validations := controller getValidations.
 	self assert: (validations isKindOf: Collection).
-	self assert: (validations isEmpty) equals: false.
-
-	self assert: (validations allSatisfy: [ :validationClass | validationClass tags asSet includes: 'Validation-Classes'. ]) equals: true.
+	self assert: validations isEmpty equals: false.
+
+	self
+		assert: (validations allSatisfy: [ :validationClass |
+				 validationClass packageTag name = 'Validation-Classes' ])
+		equals: true
 ]
 
 { #category : 'tests' }

repository/OpenPonk-BPMN/OPBPMNActivityController.class.st

@@ -22,25 +22,25 @@ OPBPMNActivityController >> buildEditorForm: aForm [
 		selectItem: self model type;
 		whenSelectedItemChangedDo: [ :newValue | 
 			self model type: newValue.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 	(aForm addCheckbox: 'Is Call Activity?')
 		state: self model isCallActivity;
 		whenChangedDo: [ :val | 
 			self model isCallActivity: val.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 	self model type = OPBPMNNodeType Service
 	| (self model type = OPBPMNNodeType Send)
 		ifTrue: [ 
 			(aForm addText: 'Executable attribute')
 				text: self model executableAttribute;
 				whenTextChangedDo: [ :newValue | 
 					self model executableAttribute: newValue asString.
-					self diagramElement modelChanged ].
+					self modelChanged ].
 			(aForm addText: 'Executable attribute value')
 				text: self model executableAttributeValue;
 				whenTextChangedDo: [ :newValue | 
 					self model executableAttributeValue: newValue asString.
-					self diagramElement modelChanged ] ]
+					self modelChanged ] ]
 		ifFalse: [ self model executableAttribute: nil ]
 ]
 

repository/OpenPonk-BPMN/OPBPMNBoundaryEventController.class.st

@@ -23,12 +23,12 @@ OPBPMNBoundaryEventController >> buildEditorForm: aForm [
 		selectItem: self model type;
 		whenSelectedItemChangedDo: [ :newValue | 
 			self model type: newValue.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 		(aForm addCheckbox: 'Is Non-Interrupting')
 		state: self model isNonInterrupting;
 		whenChangedDo: [ :val | 
 			self model isNonInterrupting: val.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 ]
 
 { #category : 'connecting' }

repository/OpenPonk-BPMN/OPBPMNCollapsedSubProcessController.class.st

@@ -25,12 +25,12 @@ OPBPMNCollapsedSubProcessController >> buildEditorForm: aForm [
 		selectItem: self model type;
 		whenSelectedItemChangedDo: [ :newValue |
 			self model type: newValue.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 	(aForm addCheckbox: 'Is Call Activity?')
 		state: self model isCallActivity;
 		whenChangedDo: [ :val |
 			self model isCallActivity: val.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 
 	(aForm addButton: 'Add Boundary Event') action: [
 		anEvent := OPBPMNBoundaryEventController new
@@ -41,15 +41,15 @@ OPBPMNCollapsedSubProcessController >> buildEditorForm: aForm [
 		"self diagramElement addBoundaryEvent: anEvent"
 		RSLocation new
 			stick: anEvent diagramElement roassalShape
-			on: self diagramElement roassalShape;
+			on: self roassalShape;
 			bottom;
 			right;
 			offset: -1 @ 22.
 		self diagramElement roassalShape
 			when: RSShapeRemovedEvent
-			do: [ anEvent diagramElement roassalShape remove ]
+			do: [ anEvent roassalShape remove ]
 			for: self ].
-	self diagramElement modelChanged
+	self modelChanged
 ]
 
 { #category : 'connecting' }

repository/OpenPonk-BPMN/OPBPMNDataObjectController.class.st

@@ -17,7 +17,7 @@ OPBPMNDataObjectController >> buildEditorForm: aForm [
 		selectItem: self model type;
 		whenSelectedItemChangedDo: [ :newValue | 
 			self model type: newValue.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 ]
 
 { #category : 'connecting' }

repository/OpenPonk-BPMN/OPBPMNEdgeControllerTest.class.st

@@ -64,6 +64,6 @@ OPBPMNEdgeControllerTest >> testFigureRefresh [
 	label := controller diagramElement ownedElements first.
 	self assert: label roassalShape text equals: ''.
 	controller model name: 'new name'.
-	controller diagramElement modelChanged.
+	controller modelChanged.
 	self assert: label roassalShape text equals: 'new name'
 ]

repository/OpenPonk-BPMN/OPBPMNEndEventController.class.st

@@ -18,19 +18,19 @@ OPBPMNEndEventController >> buildEditorForm: aForm [
 		selectItem: self model type;
 		whenSelectedItemChangedDo: [ :newValue |
 			self model type: newValue.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 	self model type = OPBPMNNodeType Send
 		ifTrue: [
 			(aForm addText: 'Executable attribute')
 				text: self model executableAttribute;
 				whenTextChangedDo: [ :newValue |
 					self model executableAttribute: newValue asString.
-					self diagramElement modelChanged ].
+					self modelChanged ].
 			(aForm addText: 'Executable attribute value')
 				text: self model executableAttributeValue;
 				whenTextChangedDo: [ :newValue |
 					self model executableAttributeValue: newValue asString.
-					self diagramElement modelChanged ] ]
+					self modelChanged ] ]
 		ifFalse: [ self model executableAttribute: nil ]
 ]
 

repository/OpenPonk-BPMN/OPBPMNFlowController.class.st

@@ -16,7 +16,7 @@ OPBPMNFlowController >> buildEditorForm: aForm [
 		selectItem: self model type;
 		whenSelectedItemChangedDo: [ :newValue | 
 			self model type: newValue.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 ]
 
 { #category : 'accessing' }

repository/OpenPonk-BPMN/OPBPMNGatewayController.class.st

@@ -19,9 +19,9 @@ OPBPMNGatewayController >> buildEditorForm: aForm [
 		displayIcon: [ :type | self model typeIconFor: type ];
 		display: [ :type | type asString ];
 		selectItem: self model type;
-		whenSelectedItemChangedDo: [ :newValue | 
+		whenSelectedItemChangedDo: [ :newValue |
 			self model type: newValue.
-			self diagramElement modelChanged ]
+			self modelChanged ]
 ]
 
 { #category : 'connecting' }

repository/OpenPonk-BPMN/OPBPMNIntermediateEventController.class.st

@@ -36,24 +36,24 @@ OPBPMNIntermediateEventController >> buildEditorForm: aForm [
 			selectItem: self model timerType;
 			whenSelectedItemChangedDo: [ :newValue |
 				self model timerType: newValue.
-				self diagramElement modelChanged ].
+				self modelChanged ].
 		(aForm addText: 'Timer value')
 			text: self model timerValue;
 			whenTextChangedDo: [ :newValue |
 				self model timerValue: newValue asString.
-				self diagramElement modelChanged ] ].
+				self modelChanged ] ].
 	self model type = OPBPMNNodeType Send
 		ifTrue: [
 			(aForm addText: 'Executable attribute')
 				text: self model executableAttribute;
 				whenTextChangedDo: [ :newValue |
 					self model executableAttribute: newValue asString.
-					self diagramElement modelChanged ].
+					self modelChanged ].
 			(aForm addText: 'Executable attribute value')
 				text: self model executableAttributeValue;
 				whenTextChangedDo: [ :newValue |
 					self model executableAttributeValue: newValue asString.
-					self diagramElement modelChanged ] ]
+					self modelChanged ] ]
 		ifFalse: [ self model executableAttribute: nil ]
 ]
 

repository/OpenPonk-BPMN/OPBPMNNodeController.class.st

@@ -15,7 +15,7 @@ OPBPMNNodeController >> buildEditorForm: aForm [
 		text: self model name;
 		whenTextChangedDo: [ :newValue | 
 			self model name: newValue asString.
-			self diagramElement modelChanged ]
+			self modelChanged ]
 ]
 
 { #category : 'announcements' }

repository/OpenPonk-BPMN/OPBPMNNodeControllerTest.class.st

@@ -37,7 +37,7 @@ OPBPMNNodeControllerTest >> testFigureRefresh [
 	self assert:
 		(controller roassalShape propertyAt: #RSLabeled) text = ''.
 	controller model name: 'new name'.
-	controller diagramElement modelChanged.
+	controller modelChanged.
 	text := (controller roassalShape propertyAt: #RSLabeled) text.
 	self assert:
 		((text last: 8) = 'new name' or: [ (text first: 8) = 'new name' ])

repository/OpenPonk-BPMN/OPBPMNPoolController.class.st

@@ -24,18 +24,18 @@ OPBPMNPoolController >> buildEditorForm: aForm [
 	super buildEditorForm: aForm.
 	(aForm addTextInput: 'Lanes')
 		text: self model lanes asString;
-		whenTextChangedDo: [ :newValue | 
+		whenTextChangedDo: [ :newValue |
 			self model lanes: (newValue asString asInteger ifNil: [ 1 ]).
 			self model laneNamesFitToLanesCount.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 
-	self model lanes > 1 ifTrue: [ 
-		1 to: self model lanes do: [ :i | 
-			(aForm addTextInput: 'Lane ', i asString)
+	self model lanes > 1 ifTrue: [
+		1 to: self model lanes do: [ :i |
+			(aForm addTextInput: 'Lane ' , i asString)
 				text: (self model laneNames at: i) asString;
-				whenTextChangedDo: [ :newValue | 
+				whenTextChangedDo: [ :newValue |
 					self model laneNamesAt: i put: newValue.
-					self diagramElement modelChanged ] ] ]
+					self modelChanged ] ] ]
 ]
 
 { #category : 'connecting' }

repository/OpenPonk-BPMN/OPBPMNPoolControllerTest.class.st

@@ -35,11 +35,10 @@ OPBPMNPoolControllerTest >> testFigureRefresh [
 	controller
 		createDiagramElement;
 		renderDiagramElement.
-	self assert:
-		(controller diagramElement label text) = ''.
+	self assert: controller diagramElement label text = ''.
 	controller model name: 'new name'.
-	controller diagramElement modelChanged.
-	text := (controller diagramElement label text).
+	controller modelChanged.
+	text := controller diagramElement label text.
 	self assert:
 		((text last: 8) = 'new name' or: [ (text first: 8) = 'new name' ])
 ]

repository/OpenPonk-BPMN/OPBPMNStartEventController.class.st

@@ -19,12 +19,12 @@ OPBPMNStartEventController >> buildEditorForm: aForm [
 		selectItem: self model type;
 		whenSelectedItemChangedDo: [ :newValue |
 			self model type: newValue.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 	(aForm addCheckbox: 'Is Non-Interrupting')
 		state: self model isNonInterrupting;
 		whenChangedDo: [ :val |
 			self model isNonInterrupting: val.
-			self diagramElement modelChanged ].
+			self modelChanged ].
 
 	self model type = OPBPMNNodeType Timer ifTrue: [
 		(aForm addDroplist: 'Timer type')
@@ -33,12 +33,12 @@ OPBPMNStartEventController >> buildEditorForm: aForm [
 			selectItem: self model timerType;
 			whenSelectedItemChangedDo: [ :newValue |
 				self model timerType: newValue.
-				self diagramElement modelChanged ].
+				self modelChanged ].
 		(aForm addText: 'Timer value')
 			text: self model timerValue;
 			whenTextChangedDo: [ :newValue |
 				self model timerValue: newValue asString.
-				self diagramElement modelChanged ] ]
+				self modelChanged ] ]
 ]
 
 { #category : 'connecting' }

repository/OpenPonk-BPMN/OPBPMNSubProcessController.class.st

@@ -22,16 +22,15 @@ OPBPMNSubProcessController >> buildEditorForm: aForm [
 			           yourself.
 		"self diagramElement addBoundaryEvent: anEvent"
 		RSLocation new
-			stick: anEvent diagramElement roassalShape
-			on: self diagramElement roassalShape;
+			stick: anEvent roassalShape on: self roassalShape;
 			bottom;
 			right;
 			offset: -5 @ 20.
-		self diagramElement roassalShape
+		self roassalShape
 			when: RSShapeRemovedEvent
-			do: [ anEvent diagramElement roassalShape remove ]
+			do: [ anEvent roassalShape remove ]
 			for: self ].
-	self diagramElement modelChanged
+	self modelChanged
 ]
 
 { #category : 'forms' }