Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add rolling stock categories #10790

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Feb 13, 2025

Close #10691
Depend on #10701

Behavior and translations should be fine, but the css could still use a little improvement ^^

@Synar Synar requested a review from a team as a code owner February 13, 2025 02:13
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 11.22449% with 87 lines in your changes missing coverage. Please review.

Project coverage is 81.87%. Comparing base (3f83ed4) to head (e2a6277).
Report is 23 commits behind head on dev.

Files with missing lines Patch % Lines
...llingStockEditor/RollingStockEditorFormHelpers.tsx 1.49% 66 Missing ⚠️
...onents/RollingStockCard/RollingStockCardDetail.tsx 0.00% 8 Missing ⚠️
...ents/RollingStockEditor/RollingStockEditorForm.tsx 0.00% 8 Missing ⚠️
front/src/modules/rollingStock/helpers/utils.ts 0.00% 4 Missing ⚠️
...tock/components/RollingStockSelector/sampleData.ts 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10790      +/-   ##
==========================================
+ Coverage   81.83%   81.87%   +0.03%     
==========================================
  Files        1081     1083       +2     
  Lines      106882   107646     +764     
  Branches      729      741      +12     
==========================================
+ Hits        87469    88130     +661     
- Misses      19372    19474     +102     
- Partials       41       42       +1     
Flag Coverage Δ
editoast 74.31% <ø> (-0.02%) ⬇️
front 89.36% <11.22%> (-0.03%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.91% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Synar Synar force-pushed the ali/add-rolling-stock-categories-in-front branch from 9d72c64 to 135feea Compare February 13, 2025 17:50
@Synar Synar requested a review from SharglutDev February 14, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: Ajouter des catégories dans l'éditeur de MR
2 participants