topology_hiding: fix encoded Contact length calculation #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to segfaults (and probable vulnerabilities) when the allocated buffer is not long enough to contain its contents. This bug was introduced in OpenSIPS@e23be5d presumably as a copy-and-paste mistake.
|
Any updates here? No progress has been made in the last 30 days, marking as stale. |
|
No updates here. |
|
Any updates here? No progress has been made in the last 30 days, marking as stale. |
|
No updates here. |
|
@jes , yes, you are totally right on this, good catch ! |
bogdan-iancu
added a commit
that referenced
this pull request
Feb 13, 2024
topology_hiding: fix encoded Contact length calculation (cherry picked from commit da20b22)
bogdan-iancu
added a commit
that referenced
this pull request
Feb 13, 2024
topology_hiding: fix encoded Contact length calculation (cherry picked from commit da20b22)
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OpenSIPS can segfault when topology_hiding's encoded Contact header is too big to fit in its calculated length.
Details
The calculated length should be accumulated in
total_len, but instead the assignment is tosuffix_len, presumably due to a copy and paste error.This bug was introduced in e23be5d presumably as a copy-and-paste mistake.
Solution
My solution is to accumulate the length in
total_leninstead of insuffix_len.Compatibility
Probably doesn't break other scenarios.
Closing issues