[maxfwd]: Fix bug is_maxfwd_lt function limit value
#3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was using the address pointer as value.
|
Any updates here? No progress has been made in the last 30 days, marking as stale. |
|
Still active |
|
Any updates here? No progress has been made in the last 30 days, marking as stale. |
|
active |
|
Great finding and fix @ar45 - thanks a lot and sorry for taking longer to merge this PR. |
bogdan-iancu
added a commit
that referenced
this pull request
Dec 16, 2024
[maxfwd]: Fix bug `is_maxfwd_lt` function limit value (cherry picked from commit e6a0c98)
bogdan-iancu
added a commit
that referenced
this pull request
Dec 16, 2024
[maxfwd]: Fix bug `is_maxfwd_lt` function limit value (cherry picked from commit e6a0c98)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
is_maxfwd_lt( val )was using a random value, the ptr address.Solution
Correctly use the int value.
Compatibility
Should be backported to all supported versions of opensips.