db_oracle: Fix issues#3505 "invalid parameter value" when do sql_query("update ...") #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GangZhuo
changed the title
liviuchircu
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Hi @GangZhuo! Both the build fix and the NULL result handling changes look good to me. Merging & backporting here. Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix issues#3505 "invalid parameter value" when do sql_query("update ...")
Details
The sql_query function currently passes a db_res pointer to the url->dbf.raw_query interface to receive query results.
However, the db_oracle_raw_query function expects a NULL value for the parameter used to receive query results when performing insert, delete, or update operations. This mismatch causes the query to fail.
Solution
Allow non-NULL parameters to be passed in, and then set the query result to NULL in the db_oracle_store_result function.
Additionally, the db_oracle_free_result function should also check if the result is not NULL.
Compatibility
Backwards compatible
Closing issues
closes #3505