General code improvements #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: W.F. Stoel <[email protected]>
Signed-off-by: Frederik Stoel <[email protected]>
Signed-off-by: W.F. Stoel <[email protected]>
Signed-off-by: Willem Frederik Stoel <[email protected]>
Signed-off-by: Frederik Stoel <[email protected]>
|
@bartpleiter and @daanvanes, could you please provide an update on the status of this PR? It seems to have been open for quite some time now. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+46
to
48
| load[load.index < datetime.now(tz=UTC)] | ||
| .idxmax() | ||
| .load.date() |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| load[load.index < datetime.now(tz=UTC)] | |
| .idxmax() | |
| .load.date() | |
| load[load.index < datetime.now(tz=UTC)].idxmax().load.date() |
| @@ -39,17 +39,16 @@ | |||
| from openstef.validation import validation | |||
|
|
|||
|
|
|||
| class DummyObjective(RegressorObjective): | |||
| ... | |||
| class DummyObjective(RegressorObjective): ... | |||
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| class DummyObjective(RegressorObjective): ... | |
| class DummyObjective(RegressorObjective): | |
| ... |
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
openstef/test/unit/model/test_basecase.py
Lines 22 to 27 in 75c5788
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
openstef/test/unit/model/test_basecase.py
Lines 41 to 46 in 75c5788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.