Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace apx with more general name #578

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Replace apx with more general name #578

wants to merge 6 commits into from

Conversation

JanMaartenvanDoorn
Copy link
Collaborator

  • removed APX
  • ensured backwards compatibility

@clara-de-smet
Copy link
Collaborator

Holding off on merging until the black formatting bug is fixed

@lschilders lschilders mentioned this pull request Dec 12, 2024
Merged
@lschilders
Copy link
Collaborator

Mind this before merging: #580 (review)

@egordm
Copy link
Collaborator

egordm commented Dec 12, 2024

I applied the feature name change to new changes as well.

The pipeline is not fixed aswell. So it's unblocked, I believe.

@JanMaartenvanDoorn
Copy link
Collaborator Author

@clara-de-smet I fixed the unit tests, all the checks are passing. Do you want to review this PR, if you approve feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clara-de-smet clara-de-smet Awaiting requested review from clara-de-smet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JanMaartenvanDoorn @clara-de-smet @lschilders @egordm @actions-user