Skip to content

docs: add fqlearn internship blog post #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

faithhunja
Copy link
Contributor

No description provided.

@faithhunja
Copy link
Contributor Author

@EverVino

@EverVino
Copy link
Contributor

EverVino commented May 30, 2024

@faithhunja as Ivan wrote could you change in the .makim.yaml file this file is in the root of project

In the .makim.yaml:

replace targets to tasks
replace target to task

And to check locally I guess you should update makim version by running poetry update, or just doing a simple reinstall of dependencies.

@faithhunja
Copy link
Contributor Author

@EverVino @xmnlab

When I make those changes in the .makim.yaml file, and run makim.preview, I get the error below:
image

@EverVino
Copy link
Contributor

EverVino commented Jun 8, 2024

Hi @faithhunja sorry for my late response. I tested it locally, making the suggested changes works.
The error maybe is due that you have and old packages in the conda virtual env, recently makim have been updated many times so maybe you have errors because that.
suggestions to run locally

conda deactivate
conda remove -n osl-web --all
conda env create -f conda/dev.yaml
conda activate osl-web
makim pages.preview

Another way to check if works It is just pushing a commit with the suggested changes and check if the CI (github Continuous Integration) gives a green light

@EverVino
Copy link
Contributor

EverVino commented Jun 8, 2024

Sorry again for my late response, I completely forgot.
I know the internship is over, so let me know if you can take this forward.

@faithhunja
Copy link
Contributor Author

Thanks for the suggestions @EverVino . It works perfectly now.

@EverVino
Copy link
Contributor

EverVino commented Jun 9, 2024

Thanks @faithhunja LGTM
@xmnlab This blog post is ready to be deployed.

@EverVino EverVino requested a review from xmnlab June 9, 2024 14:51
@xmnlab xmnlab merged commit 1c5b55d into OpenScienceLabs:main Jun 11, 2024
1 check passed
@xmnlab
Copy link
Member

xmnlab commented Jun 11, 2024

thanks @faithhunja for working on that, and
thanks @EverVino for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants