-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update infrastructure #4
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
- Coverage 98.46% 98.29% -0.17%
==========================================
Files 25 25
Lines 1110 1058 -52
==========================================
- Hits 1093 1040 -53
- Misses 17 18 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look over it and made a few small comments.
Also:
-
Don't you think the documentation could still be of use? It seems to be quite general.. but haven't had a closer look at it.
-
I cannot say much about some parts of the setup (e.g. tox vs pytest, ruff blacklisting)
Thank you @ChristianZimpelmann
Janos recommended deleting it. The docs were comprised mostly of design notes, which are rather developer documentation. I think this developer documentation is very important, but I want to use a different format ---something not on GitHub. Some of Janos' notes would be integrated into this new format.
Maybe @hmgaudecker can comment on this. |
Happy to do so, but unlikely to happen before our meeting. |
for more information, see https://pre-commit.ci
That makes sense! Just wanted to make sure that the design notes are not lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks! I do have many comments, but almost all of them should be very quick and none of them requires any discussion; if you want to leave some of the ruff things as they are, just make a quick note, please.
Leaving docformatter at v1.5.1 instead of v.1.6.0 because of incompatibilities with black. |
Let's just delete it, ruff should take care of it eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for Github to remember I browsed through changes up to this point.
(I actually did not mean to approve, else the message would not have made sense, but I might as well have. So just merge as you see fit) Thanks! |
What problem do you want to solve?
Match the code base infrastructure with that of estimagic.
Changes
Todo
Closes #XXXX
in the first PR comment to auto-close the relevant issue oncethe PR is accepted. This is not applicable if there is no corresponding issue.