-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update model processing #85
Conversation
…conomics/lcm into update-process-model
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, that is much nicer to read now!
This clarity reveals some parts that could use high-level improvements -- ofc I did not follow instructions in that respect and noted them. Feel free to push off to some issue wherever you think that is more useful, though! Or, of course, tell me that this or that comment is nonsense.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, many thanks!
In this PR, I update the model processing. I mainly focus on the following things:
process_model.py
Model
dataclass which adds autocompletion and error handling at the creation of the user modelDiscreteGrid
,LinspaceGrid
,LogspaceGrid
, which inherit from baseclassGrid
, andContinuousGrid
.create_params_template.py
black
formatter and replace byruff-formatter
(this also means we can remove nbqa)