Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add \x8F to Ę conversion for Windows-1252 #53

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

Spartan322
Copy link
Member

@Spartan322 Spartan322 commented Aug 1, 2024

Add CSV Win1252->Utf8 conversion tests

Fix map_value warning not triggering
Optimize for ascii characters

To support special vanilla Polish TODOs that break utf8

@Spartan322 Spartan322 added bug Something isn't working enhancement New feature or request labels Aug 1, 2024
@Spartan322 Spartan322 force-pushed the fix/polish-todos branch 3 times, most recently from 136a80a to 0634ecb Compare August 1, 2024 20:16
Hop311
Hop311 previously approved these changes Aug 1, 2024
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows 👍

Hop311
Hop311 previously approved these changes Aug 1, 2024
@Spartan322 Spartan322 force-pushed the fix/polish-todos branch 3 times, most recently from e2e552b to 421c450 Compare August 1, 2024 21:25
Hop311
Hop311 previously approved these changes Aug 1, 2024
@Spartan322 Spartan322 force-pushed the fix/polish-todos branch 6 times, most recently from 8c3db0b to 776cc3d Compare August 1, 2024 21:56
Hop311
Hop311 previously approved these changes Aug 1, 2024
@Spartan322 Spartan322 force-pushed the fix/polish-todos branch 5 times, most recently from 5f5051a to 061d257 Compare August 1, 2024 22:19
	To support special vanilla Polish TODOs that break utf8

Add CSV Win1252->Utf8 conversion tests

Fix map_value warning not triggering
Optimize for ascii characters
@Hop311 Hop311 merged commit f754eb9 into master Aug 2, 2024
14 checks passed
@Hop311 Hop311 deleted the fix/polish-todos branch August 2, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants