fix/entrypoint_loading #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids issues with requirement versions mismatches in skills, this should be handled at install time not runtime solution taken from: click-contrib/click-plugins#31
Codecov Report
@@ Coverage Diff @@
## dev #117 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 47
Lines ? 3197
Branches ? 0
=====================================
Hits ? 0
Misses ? 3197
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
93 tasks
NeonDaniel
reviewed
Jan 30, 2023
| except Exception as e: | ||
| LOG.exception(f"Failed to load plugin entry point {entry_point}") | ||
| return entrypoints | ||
|
|
||
|
|
||
| def _iter_entrypoints(plug_type): |
There was a problem hiding this comment.
Could we add some test case for this? Maybe a test skill branch we install that specifies an exact OPM version older than this one?
There was a problem hiding this comment.
lets do this in another PR before the next stable release, i want to get this fix out asap as this makes it really painful to use some plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids issues with requirement versions mismatches in skills, this should be handled at install time not runtime
solution taken from: click-contrib/click-plugins#31