treat windows service accounts as case insensitive #172
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmburgan
approved these changes
Aug 26, 2025
|
@binford2k can you please rebase? Tests should pass afterwards. |
ekohl
reviewed
Aug 26, 2025
|
@bastelfreak I'll tell you in 24 minutes whether the windows tests pass 😭 |
|
@binford2k now can you rebase to get rid of the merge commit? :) |
|
@bastelfreak you can squash or rebase while merging, yeah? |
Windows service accounts are *case preserving* but not *case sensitive*. Before this change, Windows service logon account names were compared directly as case sensitive. When there was a case mismatch, it was treated as a change to the account and the service was restarted. This now normalizes case before comparing, reducing spurious restarts.
binford2k
force-pushed
the
binford2k-patch-2
branch
from
408b7f5 to
aaa2aee
Compare
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows service accounts are case preserving but not case sensitive.
Before this change, Windows service logon account names were compared directly as case sensitive. When there was a case mismatch, it was treated as a change to the account and the service was restarted. This now normalizes case before comparing, reducing spurious restarts.