Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Svpbmt): support WMO memory access and outstanding of NC #3900

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

feat(Svpbmt): support WMO memory access and outstanding of NC #3900

wants to merge 21 commits into from

Conversation

Maxpicca-Li
Copy link
Member

@Maxpicca-Li Maxpicca-Li commented Nov 19, 2024 •
edited
Loading

Here, "NC" represents accesses with PBMT=1, characterized by properties such as non-cacheable, idempotent, weakly-ordered (RVWMO), and main memory. This PR supports the WMO memory access and outstanding uncache of NC. The detailed architecture diagram is as follows.
pbmt drawio

@Maxpicca-Li
feat(LDU): add support for NC in LoadUnit
34ada85
@Maxpicca-Li
feat(LQ,UB): add support for NC in load queue and uncache buffer
5f270a8
@Maxpicca-Li
feat(SQ,STU): add support for NC in store queue and storeunit
4c1e0dd
@Maxpicca-Li
fix(PBMT): skip nc difftest and handle the conflict of nc and normal …
60b230b 
…store
@Maxpicca-Li
fix(PBMT): nc st req is changed to a state machine execution
6a7f018
@Maxpicca-Li
fix(pbmt): fix typo and control error of nc ld
41e1e86
@Maxpicca-Li
fix(pbmt): nc data assignment error
ac5a3e4
@Maxpicca-Li
fix(pbmt): nc should be used to wakeup
9952e4e
@Maxpicca-Li
fix(pbmt): remove wrong assert
f231f4c
@Maxpicca-Li
fix(pbmt): lots of bugs of nc st ld forward
eb57f0a
@Maxpicca-Li
fix(pbmt): fix address align error
17d34ea
@Maxpicca-Li
chore(pbmt): add xsperf for nc ld statistic
2733352
@Maxpicca-Li
feat(uncache): change queue to buffer to prepare for outstanding
a10d648
@Maxpicca-Li
feat(uncache): optimize the buffer's pipeline to align with original …
b16ca24 
…performance
@Maxpicca-Li
feat(outstanding): support nc outstanding and remove mmio st outstanding
92af09c
@Maxpicca-Li Maxpicca-Li added the testing beta for CI test, not merged temporarily label Nov 19, 2024
@Maxpicca-Li Maxpicca-Li changed the title Svpbmt: support wmo memory access and outstanding of nc Svpbmt: support WMO memory access and outstanding of nc Nov 19, 2024
@Maxpicca-Li Maxpicca-Li changed the title Svpbmt: support WMO memory access and outstanding of nc Svpbmt: support WMO memory access and outstanding of NC Nov 19, 2024
@Maxpicca-Li Maxpicca-Li self-assigned this Nov 19, 2024
@Maxpicca-Li Maxpicca-Li marked this pull request as draft November 19, 2024 13:50
@Maxpicca-Li Maxpicca-Li changed the title Svpbmt: support WMO memory access and outstanding of NC feat(Svpbmt): support WMO memory access and outstanding of NC Nov 19, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 92af09c

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
92af09c 1.917 0.450 2.701 1.229 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
aecf601 1.917 0.450 2.701 1.237 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
03426fe 1.917 0.450 2.701 1.221 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
39d5540 1.917 0.450 2.701 1.235 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
92f3664 1.917 0.450 2.701 1.227 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
3e2285d 1.917 0.450 2.701 1.226 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 8719682

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
8719682 1.917 0.450 2.701 1.229 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
92bcee1 1.917 0.450 2.701 1.230 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
09910ab
531dd12 1.917 0.450 2.701 1.228 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
6639e9a

@Maxpicca-Li Maxpicca-Li marked this pull request as ready for review November 27, 2024 13:12
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 73f086b

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
73f086b 1.917 0.450 2.701 1.232 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
b00d582 1.917 0.450 2.701 1.230 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
e718f87
3956160 1.917 0.450 2.701 1.233 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
0d6f7fa 1.917 0.450 2.701 1.232 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
a5c77bc 1.917 0.450 2.701 1.230 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidingliu weidingliu Awaiting requested review from weidingliu weidingliu is a code owner

@good-circle good-circle Awaiting requested review from good-circle good-circle is a code owner

@cz4e cz4e Awaiting requested review from cz4e cz4e is a code owner

@happy-lx happy-lx Awaiting requested review from happy-lx happy-lx is a code owner

@cebarobot cebarobot Awaiting requested review from cebarobot cebarobot is a code owner

@Lemover Lemover Awaiting requested review from Lemover Lemover is a code owner

@bosscharlie bosscharlie Awaiting requested review from bosscharlie bosscharlie is a code owner

@linjuanZ linjuanZ Awaiting requested review from linjuanZ linjuanZ is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Maxpicca-Li Maxpicca-Li

Labels
testing beta for CI test, not merged temporarily
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maxpicca-Li @XiangShanRobot @linjuanZ