Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate initializer to ERC721 (with no metadata) #1260

Open
ericnordelo opened this issue Dec 17, 2024 · 0 comments
Open

Add a separate initializer to ERC721 (with no metadata) #1260

ericnordelo opened this issue Dec 17, 2024 · 0 comments
Assignees
Milestone

Comments

@ericnordelo
Copy link
Member

🧐 Motivation
The existing ERC721Component initializer registers both IERC721_ID and IERC721_METADATA_ID, while the IERC721Metadata is described as optional in the EIP. Users could choose not to implement that interface, but if they call the given initializer, this will lead to an inconsistency that could break some UIs.

📝 Details
A second initializer can be added to be used in this case (not registering the IERC721_METADATA_ID). In-code comments and documentation must be detailed about the potential issue and when to use each initializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants