Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initializer_no_metadata to erc721 component #1276

Conversation

andrew-fleming
Copy link
Collaborator

Fixes #1260. Note that this PR is targeting the release branch v0.20.0-rc.0. Happy to change the target branch to main if that seems better/easier

*Wizard needs to be updated with this when released

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (f0edfaa) to head (3ffbe0e).
Report is 3 commits behind head on release-v1.0.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-v1.0.0    #1276      +/-   ##
==================================================
+ Coverage           92.26%   95.21%   +2.94%     
==================================================
  Files                  59       59              
  Lines                1811     1483     -328     
==================================================
- Hits                 1671     1412     -259     
+ Misses                140       71      -69     
Files with missing lines Coverage Δ
...kages/access/src/accesscontrol/accesscontrol.cairo 71.42% <ø> (-1.91%) ⬇️
packages/access/src/ownable/ownable.cairo 81.25% <ø> (ø)
packages/account/src/account.cairo 100.00% <ø> (+2.08%) ⬆️
packages/account/src/eth_account.cairo 100.00% <ø> (+1.88%) ⬆️
...ges/account/src/extensions/src9/snip12_utils.cairo 100.00% <ø> (+52.94%) ⬆️
packages/account/src/extensions/src9/src9.cairo 89.47% <ø> (-2.20%) ⬇️
packages/account/src/utils.cairo 100.00% <ø> (+9.09%) ⬆️
packages/account/src/utils/secp256_point.cairo 91.66% <ø> (+10.41%) ⬆️
packages/account/src/utils/signature.cairo 100.00% <ø> (+12.50%) ⬆️
packages/finance/src/vesting/vesting.cairo 100.00% <ø> (ø)
... and 44 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0edfaa...3ffbe0e. Read the comment docs.

@ericnordelo
Copy link
Member

Hey @andrew-fleming , the PR looks great! We should target release-v1.0.0 instead, since this is the branch that should contain fixes and things we want to include in the audited release. We should let the auditors know about updates on this branch.

@andrew-fleming andrew-fleming changed the base branch from release-v0.20.0-rc.0 to release-v1.0.0 December 30, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants