Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of permutations in merkle tree leave hashing #1268

Open
ericnordelo opened this issue Dec 19, 2024 · 3 comments · May be fixed by #1280
Open

Reduce the number of permutations in merkle tree leave hashing #1268

ericnordelo opened this issue Dec 19, 2024 · 3 comments · May be fixed by #1280
Milestone
2. next

Comments

@ericnordelo
Copy link
Member

In the poseidon hasher we can use h(x,y)=hades(x,y,2), which is 1 permutation less compared to state.update(x).update(y).finalize(), since the latter adds a permutation whenever we transition from odd --> even # of arguments (so only one so far) + another one for finalization.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Dec 19, 2024
@ericnordelo ericnordelo added this to the 2. next milestone Dec 19, 2024
@0x471
Copy link

0x471 commented Dec 28, 2024

Hi, can I work on this issue? @ericnordelo

@ericnordelo
Copy link
Member Author

Hi, can I work on this issue? @ericnordelo

Hi, sure! Feel free to open a PR.

@0x471 0x471 linked a pull request Jan 1, 2025 that will close this issue
Open
4 tasks
@0x471
Copy link

0x471 commented Jan 1, 2025

Hey @ericnordelo. Please review the PR in your free time. I would be happy to adjust and work on it further accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Contracts for Cairo
Status: 📋 Backlog
Milestone
2. next
Development

Successfully merging a pull request may close this issue.

perf(merkle): optimize Poseidon hash using direct hades_permutation 0x471/cairo-contracts
2 participants
@ericnordelo @0x471