perf(merkle): optimize Poseidon hash using direct hades_permutation #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericnordelo
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Hey, the update looks good. You need to run scarb fmt -w for the linter, and some tests need to be fixed as well, which can be more time-consuming. Note that when the PR is ready, it still may take some time to get merged, since we also need to update https://github.com/ericnordelo/strk-merkle-tree to make it compatible with the new format.
| @@ -33,14 +34,15 @@ pub impl PedersenCHasher of CommutativeHasher { | |||
|
|
|||
| /// Computes the Poseidon commutative hash of a sorted pair of felt252 values. | |||
| pub impl PoseidonCHasher of CommutativeHasher { | |||
| /// Computes the Poseidon hash of the concatenation of two values, sorting the pair first. | |||
| /// Computes the Poseidon hash by directly using hades_permutation with the two values | |||
There was a problem hiding this comment.
Suggested change
| /// Computes the Poseidon hash by directly using hades_permutation with the two values | |
| /// Computes the Poseidon hash of two values, sorting the pair first. |
|
Thanks for the review, @ericnordelo . Feel free to ping me once the other dependencies are ready. I’d be happy to finalize and prepare it for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1268
PR Checklist