Add Governor component #1180
Add Governor component #1180
Conversation
…eleased-package-#1141
…emove-dual-dispatchers
…eat/remove-mocks-from-released-package-#1141
* feat: remove modules * fix: mock * fix: linter * fix: tests * fix: mock * feat: apply review suggestions
…om-released-package-#1141
…eat/remove-mocks-from-released-package-#1141
…eat/remove-mocks-from-released-package-#1141
…eat/remove-mocks-from-released-package-#1141
packages/governance/src/governor/extensions/governor_counting_simple.cairo
Outdated
Show resolved
Hide resolved
packages/governance/src/governor/extensions/governor_timelock_execution.cairo
Outdated
Show resolved
Hide resolved
packages/governance/src/governor/extensions/governor_votes_quorum_fraction.cairo
Outdated
Show resolved
Hide resolved
| /// Temporary defined as a function since constant ByteArray is not supported yet. | ||
| fn DEFAULT_PARAMS() -> Span<felt252>; |
There was a problem hiding this comment.
We should adjust the comment. Maybe test this with a non-empty span, WDYT?
There was a problem hiding this comment.
Comment adjusted. Will revisit tests after finishing tests for extensions.
…eat/governance2-#294
| .execute_batch(calls, 0, this_component.timelock_salt(description_hash)); | ||
|
|
||
| // Cleanup | ||
| this_component.Governor_timelock_ids.write(proposal_id, 0); |
There was a problem hiding this comment.
It may be a bit more secure to update the state prior to making an external call, guards against reentrancy
There was a problem hiding this comment.
Note that there are no checks associated with the value for this particular case. Even if we don't update the value it should be ok, since the state of the timelock proposal should be correct one even if we don't remove the id. Also, the target of the execute may want to verify the state of the proposal at some point, and the id being accessible can help with that.
| /// NOTE: This function does not emit an event if the new voting delay is the same as the | ||
| /// old one. |
There was a problem hiding this comment.
Could be more clear if we move the note here and in the similar functions to the end of the function description
There was a problem hiding this comment.
Let's keep the "Emit event" section at the end for consistency, but let's put the note right on top.
packages/governance/src/governor/extensions/governor_settings.cairo
Outdated
Show resolved
Hide resolved
…eat/governance2-#294
Fixes #294
PR Checklist