Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permit hash #1283

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Fix permit hash #1283

merged 4 commits into from
Jan 6, 2025

Conversation

andrew-fleming
Copy link
Collaborator

And to compare with hash output from starknetjs: https://gist.github.com/andrew-fleming/5b9fa7f1a1d7158d56292cd3f8ac0fef

ericnordelo
ericnordelo approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @andrew-fleming!

@andrew-fleming andrew-fleming merged commit 39950b7 into OpenZeppelin:main Jan 6, 2025
6 checks passed
@andrew-fleming andrew-fleming deleted the fix-permit-hash branch January 6, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnordelo ericnordelo ericnordelo approved these changes

@immrsd immrsd Awaiting requested review from immrsd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-fleming @ericnordelo