Add presets page update on release workflow #883
Conversation
…eat/class-hash-action
ericnordelo
changed the title
update class hashes workflowCheck class hashes workflow
ericnordelo
changed the title
Check class hashes workflow
|
I removed the local javascript action and addressed Andrew's comments, but I found myself spending an important amount of time developing the action in bash, so I just created a python script for it. I don't think it is worth spending the time on implementing what the python script does directly in bash. Let me know if you think otherwise. |
…eat/class-hash-action
| env: | ||
| SCARB_VERSION: 2.5.3 |
There was a problem hiding this comment.
what's our strategy to maintain this up to date?
There was a problem hiding this comment.
My idea is to continue using the same we've been using: update this version at the same time we update the Scarb.toml. We had to do this already for the lint_and_test action.
There was a problem hiding this comment.
i see. does it make sense to automate it in some way? is there something preventing us from mistakenly not updating it?
There was a problem hiding this comment.
I'm under the impression it might be easy to forget about this bump and mistakenly publish the wrong hashes. what about reading it from Scarb.toml?
Co-authored-by: Martín Triay <[email protected]>
No description provided.