-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Merkle Proof Verifier #970
Conversation
Hey @boray thanks for taking the time! This would be a nice addition and we are happy to merge it after is finished and reviewed. We will be happy to review the PR after tests and logic are finished. |
Could we have this merged ASAP? I need it in a repo i'm working on and i'd rather skip implementing it from scratch |
Hey @ametel01, this PR is from an external contributor, and we will be happy to review it and merge it as soon as it is ready, It is also part of our roadmap for the next milestone, so we plan on working on that in the next three weeks. Note that Cairo 2.7 introduces some important changes, so we can't really release until we have the full cairo version out. |
@ericnordelo understandable |
@ericnordelo also waiting to use a MerkleProof Verifier library for some work we're doing at Chainlink. I see that the the rc's for Cairo 2.7 are out already. Do you have an idea of when this work could be completed? |
We will start working on it right after finishing this release. The reason is mainly these changes that conflict and must be included first. |
Fixes #936
I implemented MerkleProof.sol in Cairo.
This is a draft and needs improvement. It uses only Poseidon for now. That should be abstracted to work with Pedersen and Keccak. Testing coverage is narrow and should be extended.
I am waiting for your comments.
PR Checklist