Update submodules and remove files that migrated to the vanilla repo #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
force-pushed
the
chore/vanilla-migration-pruning
branch
from
80a5a78 to
7ea3da9
Compare
|
We can't merge this until the documentation in vanilla is available. Also, we need to remove the documentation that we migrated to vanilla and make sure all references go to vanilla instead |
|
Do we get documentation with the RC, or only with final releases? |
|
We get it with the RC afaik. |
| @@ -4,10 +4,6 @@ NOTE: This document is better viewed at https://docs.openzeppelin.com/community- | |||
|
|
|||
| This directory includes contracts to build accounts for ERC-4337. These include: | |||
|
|
|||
| * {Account}: An ERC-4337 smart account implementation that includes the core logic to process user operations. | |||
There was a problem hiding this comment.
Very minor & pretty out-of-scope:
to be updated in
https://docs.openzeppelin.com/community-contracts/access.
Comment on lines
+27
to
+31
| clear: `$clear(uint256)`, // `$clear_EnumerableSetExtended_${name}(uint256)` when more types are added | ||
| length: `$length(uint256)`, // `$length_EnumerableSetExtended_${name}(uint256)` when more types are added | ||
| at: `$at(uint256,uint256)`, // `$at_EnumerableSetExtended_${name}(uint256,uint256)` when more types are added | ||
| values: `$values(uint256)`, // `$values_EnumerableSetExtended_${name}(uint256)` when more types are added | ||
| valuesPage: `$values(uint256,uint256,uint256)`, // `$values_EnumerableSetExtended_${name}(uint256,uint256,uint256)` when more types are added |
There was a problem hiding this comment.
Do we still need these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite big !
ERC20Mock.sol& co (in favor of$ERC20.sol)contracts/interfaces/IERC7786.sol(^0.8.0 -> ^0.8.4).github/actions/setup/action.yml(migration to node 22.x)Removed files