Update Truffle and Solium #1105
Conversation
nventuro
added
kind:improvement
automation
There was a problem hiding this comment.
Great work, thanks @vittominacori! I left some nitpicking comments, will see if I can figure out the linebreak thing.
contracts/access/Whitelist.sol
Outdated
| @@ -52,8 +52,8 @@ contract Whitelist is Ownable, RBAC { | |||
| * false if all addresses were already in the whitelist | |||
| */ | |||
| function addAddressesToWhitelist(address[] _operators) | |||
| onlyOwner | |||
| public | |||
| public | |||
There was a problem hiding this comment.
isn't there an indentation missing here? @ElOpio you experimented a bit with Solium, any ideas on why it didn't catch this?
| @@ -45,7 +45,7 @@ contract('HasNoEther', function (accounts) { | |||
| const ownerFinalBalance = await ethGetBalance(accounts[0]); | |||
| const finalBalance = await ethGetBalance(hasNoEther.address); | |||
| assert.equal(finalBalance, 0); | |||
| assert.isAbove(ownerFinalBalance, ownerStartBalance); | |||
| assert.isTrue(ownerFinalBalance.greaterThan(ownerStartBalance)); | |||
There was a problem hiding this comment.
There is a separate issue (#1091) for this, try to only commit relevant changes :)
| uint256, | ||
| bytes) | ||
| public | ||
| returns(bytes4) |
|
Turns out that file had Windows-style line endings, which Solium caught. I changed them to Unix-style (same as the rest of the project). |
…idity into feature/update-truffle-and-solium # Conflicts: # contracts/access/rbac/Roles.sol # contracts/examples/RBACWithAdmin.sol # contracts/lifecycle/TokenDestructible.sol # contracts/ownership/Contactable.sol # contracts/token/ERC20/RBACMintableToken.sol # contracts/token/ERC721/ERC721Holder.sol # contracts/token/ERC721/ERC721Token.sol # package-lock.json
|
@nventuro I merged again from master. |
|
Agreed, these big PRs are better not left open for too long. Thanks once again @vittominacori! |
🚀 Description
This PR is to force update to Truffle 4.1.13 and Solium 1.1.8.
I solved all warnings regarding
visibility-firstandmax-len.There are many warnings regarding missing require message (
error-reason) that everyone should address.I'm having a
linebreak-styleissue with RBACCappedTokenMock.But I think it is a solium issue so I can't resolve it. Travis test.
npm run lint:all:fix).