[Feature]: ERC721Wrapper extension #2449
check.yml
on: pull_request
nightly / fmt
21s
nightly / doc
1m 5s
ubuntu / stable / features
2m 10s
ubuntu / stable / typos
3s
Matrix: clippy
Annotations
5 errors and 35 warnings
ubuntu / stable / typos
Process completed with exit code 2.
|
beta / clippy
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
beta / clippy
reviewdog exited with status code: 1
|
stable / clippy
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
stable / clippy
reviewdog exited with status code: 1
|
ubuntu / stable / typos:
contracts/src/token/erc721/extensions/wrapper.rs#L172
"taht" should be "that".
|
nightly / fmt
Cache not found for keys: v0-rust-fmt-Linux-3513b6fe-55276120, v0-rust-fmt-Linux-3513b6fe
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L19
[clippy] reported by reviewdog 🐶
warning: unused import: `RECEIVER_FN_SELECTOR`
--> contracts/src/token/erc721/extensions/wrapper.rs:19:47
|
19 | self, Erc721, IErc721 as IErc721Solidity, RECEIVER_FN_SELECTOR,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:19:47:w:warning: unused import: `RECEIVER_FN_SELECTOR`
--> contracts/src/token/erc721/extensions/wrapper.rs:19:47
|
19 | self, Erc721, IErc721 as IErc721Solidity, RECEIVER_FN_SELECTOR,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L144
[clippy] reported by reviewdog 🐶
warning: unused variable: `operator`
--> contracts/src/token/erc721/extensions/wrapper.rs:144:9
|
144 | operator: Address,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operator`
|
= note: `#[warn(unused_variables)]` on by default
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:144:9:w:warning: unused variable: `operator`
--> contracts/src/token/erc721/extensions/wrapper.rs:144:9
|
144 | operator: Address,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operator`
|
= note: `#[warn(unused_variables)]` on by default
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L92
[clippy] reported by reviewdog 🐶
warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:101:13
|
101 | / self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
| |__________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `-W clippy::missing-panics-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_panics_doc)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:92:5:w:warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:101:13
|
101 | / self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
| |__________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `-W clippy::missing-panics-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_panics_doc)]`
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L92
[clippy] reported by reviewdog 🐶
warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `-W clippy::missing-errors-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_errors_doc)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:92:5:w:warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `-W clippy::missing-errors-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_errors_doc)]`
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L95
[clippy] reported by reviewdog 🐶
warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:95:20
|
95 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:95:20:w:warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:95:20
|
95 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L100
[clippy] reported by reviewdog 🐶
warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:100:9
|
100 | / token_ids.iter().for_each(|&token_id| {
101 | | self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
... |
106 | | .expect("mint failed");
107 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
= note: `-W clippy::needless-for-each` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_for_each)]`
help: try
|
100 ~ for &token_id in token_ids.iter() {
101 + self.erc721
102 + .transfer_from(sender, contract::address(), token_id)
103 + .expect("transfer failed");
104 + erc721
105 + ._safe_mint(account, token_id, &vec![].into())
106 + .expect("mint failed");
107 + }
|
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:100:9:w:warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:100:9
|
100 | / token_ids.iter().for_each(|&token_id| {
101 | | self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
... |
106 | | .expect("mint failed");
107 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
= note: `-W clippy::needless-for-each` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_for_each)]`
help: try
|
100 ~ for &token_id in token_ids.iter() {
101 + self.erc721
102 + .transfer_from(sender, contract::address(), token_id)
103 + .expect("transfer failed");
104 + erc721
105 + ._safe_mint(account, token_id, &vec![].into())
106 + .expect("mint failed");
107 + }
|
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L120
[clippy] reported by reviewdog 🐶
warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:129:13
|
129 | / erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
| |________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:120:5:w:warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:129:13
|
129 | / erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
| |________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L120
[clippy] reported by reviewdog 🐶
warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:120:5:w:warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L123
[clippy] reported by reviewdog 🐶
warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:123:20
|
123 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:123:20:w:warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:123:20
|
123 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
__END__
|
beta / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L128
[clippy] reported by reviewdog 🐶
warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:128:9
|
128 | / token_ids.iter().for_each(|&token_id| {
129 | | erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
... |
134 | | .expect("transfer failed");
135 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
help: try
|
128 ~ for &token_id in token_ids.iter() {
129 + erc721
130 + ._update(Address::ZERO, token_id, sender)
131 + .expect("update failed");
132 + self.erc721
133 + .safe_transfer_from(contract::address(), account, token_id)
134 + .expect("transfer failed");
135 + }
|
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:128:9:w:warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:128:9
|
128 | / token_ids.iter().for_each(|&token_id| {
129 | | erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
... |
134 | | .expect("transfer failed");
135 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
help: try
|
128 ~ for &token_id in token_ids.iter() {
129 + erc721
130 + ._update(Address::ZERO, token_id, sender)
131 + .expect("update failed");
132 + self.erc721
133 + .safe_transfer_from(contract::address(), account, token_id)
134 + .expect("transfer failed");
135 + }
|
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L19
[clippy] reported by reviewdog 🐶
warning: unused import: `RECEIVER_FN_SELECTOR`
--> contracts/src/token/erc721/extensions/wrapper.rs:19:47
|
19 | self, Erc721, IErc721 as IErc721Solidity, RECEIVER_FN_SELECTOR,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:19:47:w:warning: unused import: `RECEIVER_FN_SELECTOR`
--> contracts/src/token/erc721/extensions/wrapper.rs:19:47
|
19 | self, Erc721, IErc721 as IErc721Solidity, RECEIVER_FN_SELECTOR,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L144
[clippy] reported by reviewdog 🐶
warning: unused variable: `operator`
--> contracts/src/token/erc721/extensions/wrapper.rs:144:9
|
144 | operator: Address,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operator`
|
= note: `#[warn(unused_variables)]` on by default
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:144:9:w:warning: unused variable: `operator`
--> contracts/src/token/erc721/extensions/wrapper.rs:144:9
|
144 | operator: Address,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_operator`
|
= note: `#[warn(unused_variables)]` on by default
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L92
[clippy] reported by reviewdog 🐶
warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:101:13
|
101 | / self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
| |__________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `-W clippy::missing-panics-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_panics_doc)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:92:5:w:warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:101:13
|
101 | / self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
| |__________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
= note: `-W clippy::missing-panics-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_panics_doc)]`
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L92
[clippy] reported by reviewdog 🐶
warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `-W clippy::missing-errors-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_errors_doc)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:92:5:w:warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:92:5
|
92 | / pub fn deposit_for(
93 | | &mut self,
94 | | account: Address,
95 | | token_ids: Vec<U256>,
96 | | erc721: &mut Erc721,
97 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `-W clippy::missing-errors-doc` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::missing_errors_doc)]`
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L95
[clippy] reported by reviewdog 🐶
warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:95:20
|
95 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:95:20:w:warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:95:20
|
95 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L100
[clippy] reported by reviewdog 🐶
warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:100:9
|
100 | / token_ids.iter().for_each(|&token_id| {
101 | | self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
... |
106 | | .expect("mint failed");
107 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
= note: `-W clippy::needless-for-each` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_for_each)]`
help: try
|
100 ~ for &token_id in token_ids.iter() {
101 + self.erc721
102 + .transfer_from(sender, contract::address(), token_id)
103 + .expect("transfer failed");
104 + erc721
105 + ._safe_mint(account, token_id, &vec![].into())
106 + .expect("mint failed");
107 + }
|
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:100:9:w:warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:100:9
|
100 | / token_ids.iter().for_each(|&token_id| {
101 | | self.erc721
102 | | .transfer_from(sender, contract::address(), token_id)
103 | | .expect("transfer failed");
... |
106 | | .expect("mint failed");
107 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
= note: `-W clippy::needless-for-each` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_for_each)]`
help: try
|
100 ~ for &token_id in token_ids.iter() {
101 + self.erc721
102 + .transfer_from(sender, contract::address(), token_id)
103 + .expect("transfer failed");
104 + erc721
105 + ._safe_mint(account, token_id, &vec![].into())
106 + .expect("mint failed");
107 + }
|
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L120
[clippy] reported by reviewdog 🐶
warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:129:13
|
129 | / erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
| |________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:120:5:w:warning: docs for function which may panic missing `# Panics` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
note: first possible panic found here
--> contracts/src/token/erc721/extensions/wrapper.rs:129:13
|
129 | / erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
| |________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L120
[clippy] reported by reviewdog 🐶
warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:120:5:w:warning: docs for function returning `Result` missing `# Errors` section
--> contracts/src/token/erc721/extensions/wrapper.rs:120:5
|
120 | / pub fn withdraw_to(
121 | | &mut self,
122 | | account: Address,
123 | | token_ids: Vec<U256>,
124 | | erc721: &mut Erc721,
125 | | ) -> Result<bool, Error> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L123
[clippy] reported by reviewdog 🐶
warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:123:20
|
123 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:123:20:w:warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/token/erc721/extensions/wrapper.rs:123:20
|
123 | token_ids: Vec<U256>,
| ^^^^^^^^^ help: consider changing the type to: `&[U256]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
__END__
|
stable / clippy:
contracts/src/token/erc721/extensions/wrapper.rs#L128
[clippy] reported by reviewdog 🐶
warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:128:9
|
128 | / token_ids.iter().for_each(|&token_id| {
129 | | erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
... |
134 | | .expect("transfer failed");
135 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
help: try
|
128 ~ for &token_id in token_ids.iter() {
129 + erc721
130 + ._update(Address::ZERO, token_id, sender)
131 + .expect("update failed");
132 + self.erc721
133 + .safe_transfer_from(contract::address(), account, token_id)
134 + .expect("transfer failed");
135 + }
|
Raw Output:
contracts/src/token/erc721/extensions/wrapper.rs:128:9:w:warning: needless use of `for_each`
--> contracts/src/token/erc721/extensions/wrapper.rs:128:9
|
128 | / token_ids.iter().for_each(|&token_id| {
129 | | erc721
130 | | ._update(Address::ZERO, token_id, sender)
131 | | .expect("update failed");
... |
134 | | .expect("transfer failed");
135 | | });
| |___________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_for_each
help: try
|
128 ~ for &token_id in token_ids.iter() {
129 + erc721
130 + ._update(Address::ZERO, token_id, sender)
131 + .expect("update failed");
132 + self.erc721
133 + .safe_transfer_from(contract::address(), account, token_id)
134 + .expect("transfer failed");
135 + }
|
__END__
|
nightly / doc
Cache not found for keys: v0-rust-doc-Linux-3513b6fe-55276120, v0-rust-doc-Linux-3513b6fe
|
nightly / doc:
contracts/src/token/erc721/extensions/wrapper.rs#L19
unused import: `RECEIVER_FN_SELECTOR`
|
nightly / doc:
contracts/src/token/erc721/extensions/wrapper.rs#L144
unused variable: `operator`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L19
unused import: `RECEIVER_FN_SELECTOR`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L144
unused variable: `operator`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L19
unused import: `RECEIVER_FN_SELECTOR`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L144
unused variable: `operator`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L19
unused import: `RECEIVER_FN_SELECTOR`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L144
unused variable: `operator`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L19
unused import: `RECEIVER_FN_SELECTOR`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L144
unused variable: `operator`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L19
unused import: `RECEIVER_FN_SELECTOR`
|
ubuntu / stable / features:
contracts/src/token/erc721/extensions/wrapper.rs#L144
unused variable: `operator`
|