Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow account reset codebuild access to custom nuke config bucket #issue409 #412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

morganpa
Copy link

Proposed changes

Allow account reset codebuild to access s3 bucket and key for custom aws nuke yaml
fix for #409

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@morganpa morganpa changed the title allow account reset codebuild access to custom nuke config bucketgit #issue409 allow account reset codebuild access to custom nuke config bucket #issue409 Sep 20, 2021
@cduranleau
Copy link

@jayanandagit any update here? We're looking to consume DCE in the next month or so but it won't work with our stack if we don't have this custom nuke config.

@fivehorizons
Copy link

Any chance to update aws-nuke to new version to cover new services?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants