Update use Query instead of Scan #506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfish25
reviewed
Nov 21, 2024
pkg/db/db.go
Outdated
| } | ||
| } | ||
|
|
||
| output, err := db.Client.Scan(scanInput) | ||
| output, err := db.Client.Query(queryInput) |
There was a problem hiding this comment.
Can we only do the query if an index field is present, and a scan otherwise?
bjfish25
reviewed
Nov 26, 2024
| @@ -628,13 +628,16 @@ func (db *DB) GetLeases(input GetLeasesInput) (GetLeasesOutput, error) { | |||
| filters := make([]string, 0) | |||
| filterValues := make(map[string]*dynamodb.AttributeValue) | |||
|
|
|||
| queryInput := &dynamodb.QueryInput{ | |||
| TableName: aws.String(db.LeaseTableName), | |||
| ConsistentRead: aws.Bool(db.ConsistentRead), | |||
There was a problem hiding this comment.
Would this work given that no index is given?
I think the easist way to accomplish this is
- Go back to largely how it was
- Make a variable called, queryable, and queryIndex (or something like that) and mark it false to start
- If one of the index filters are set, set the field (make sure not to overwrite, we probably want to prioritize principal_id)
- Make the query with filters if queryable, make the scan with filters otherwise
- Output the results to the same spot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesRelevant Links
Further comments