Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard coded pin paths at different locations making use of the testbench_top variable #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mathieuperret01
Copy link

Hi All,

Needed to add the options[:testbench_top] called also for forced signals in the template/probe.tcl.erb.
I also modified the origen_sim/origen_tester/api.rb, which also has a hard coded 'origen.dut' in the sim_capture function.

So the hard coded path: origen.dut or origen.debug is now removed from the template/probe.tcl
I noticed it is also present at other locations: like in template/empty.svcf (and others), which makes that default setup signals cannot be found, in case a different testbench_top is used (i.o. 'origen') => problem is that this emty.svcf (and others) is not an .erb file, and is not compiled in origen_sim => it would be nice to have that implemented, but I am not sure how.

@ginty
Copy link
Member

ginty commented Jun 1, 2023

I think for the ones that are not templates today, it's just a matter of renaming them, e.g. empty.svcf => empty.svcf.erb (to indicate that they contain dynamic content) and then adding whatever dynamic markup you need.

Would indeed be good to update them all in this PR if you can.

@mathieuperret01
Copy link
Author

Hi Stephen,
Yes, I did try that. (naively ? :))
But the empty.svcf.erb is not compiled, and saved as is, in the waves.
So I guess, a compile must be implemented in origen_sim for this specific files, is we change them to .erb

@mathieuperret01
Copy link
Author

Hi All,
Can we merge this PR ?
I am also wondering: what's next: new tag ? new gem ?
Thanks.

@redxeth redxeth requested review from priyavadan and ginty August 23, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants