Allow for proxy connection with username and pw authentication HTTP #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized the reason why I had to make the second commit: first commit mallocs proxy_user/pw and server_user/pw to some local variable then passes by reference to the HttpProtocol attributes and I attempted to free them in the destructor. Instead, malloc should be called on the object attributes directly. Will fix. |
…ixed problem that led to second commit temp which was a temp fix).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to allow for proxy connection with username and pw using mostly below code
https://msdn.microsoft.com/en-us/library/windows/desktop/aa383144(v=vs.85).aspx
But modified to allow for Basic Authentication.