Fix error processor breaking checkout when a shipping request fails #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a request fails during the shipping step (before the payment step) and does not return valid JSON, the error processor mixin fails because
responseJSON
is undefined:Additionally,
quote.paymentMethod()
is not given within shipping step, which also fails even if we fix the the first issue.This currently results in the loading screen remaining visible and prevents checkout in some cases (especially with custom functionality in the shipping step).
This issue can be resolved with minimal changes by using optional chaining: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining