Merge pull request #276 from BoulangerV/OX6-156-Change_hash_calculation

OX6-156: Update hash method
PAYONE-GmbH · Feb 5, 2024 · 8075be7 · 8075be7
2 parents 0b2fde5 + dc0ac27
commit 8075be7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 50 deletions.
diff --git a/application/views/admin/tpl/fcpayone_main.tpl b/application/views/admin/tpl/fcpayone_main.tpl
@@ -91,19 +91,6 @@
                 </dd>
                 <div class="spacer"></div>
             </dl>
-            <dl>
-                <dt>
-                    <select name="confstrs[sFCPOHashMethod]">
-                        <option value="md5" [{if $confstrs.sFCPOHashMethod == "md5"}]SELECTED[{/if}]>md5</option>
-                        <option value="sha2-384" [{if $confstrs.sFCPOHashMethod == "sha2-384"}]SELECTED[{/if}]>sha2-384 (empfohlen)</option>
-                    </select>
-                    [{oxinputhelp ident="FCPO_HELP_HASH_METHOD"}]
-                </dt>
-                <dd>
-                    [{oxmultilang ident="FCPO_HASH_METHOD"}]
-                </dd>
-                <div class="spacer"></div>
-            </dl>
         </div>
     </div>
 

diff --git a/core/fcpayone_events.php b/core/fcpayone_events.php
@@ -1018,14 +1018,6 @@ public static function deactivatePaymethods()
     public static function setDefaultConfigValues()
     {
         $oConfig = self::$_oFcpoHelper->fcpoGetConfig();
-        $blIsUpdate = self::isUpdate();
-        $blHashMethodSet = (bool) $oConfig->getConfigParam('sFCPOHashMethod');
-
-        if (!$blHashMethodSet && $blIsUpdate) {
-            $oConfig->saveShopConfVar('str', 'sFCPOHashMethod', 'md5');
-        } else if (!$blHashMethodSet) {
-            $oConfig->saveShopConfVar('str', 'sFCPOHashMethod', 'sha2-384');
-        }
 
         if (!$oConfig->getConfigParam('sFCPOAddresscheck')) {
             $oConfig->saveShopConfVar('str', 'sFCPOAddresscheck', 'NO');

diff --git a/extend/application/controllers/fcPayOnePaymentView.php b/extend/application/controllers/fcPayOnePaymentView.php
@@ -832,8 +832,6 @@ public function fcGetLangId()
      */
     public function getHashCC($sType = '') 
     {
-        $oConfig = $this->_oFcpoHelper->fcpoGetConfig();
-        $sFCPOHashMethod = $oConfig->getConfigParam('sFCPOHashMethod');
         $sKey = $this->getPortalKey();
 
         $sData =
@@ -846,13 +844,7 @@ public function getHashCC($sType = '')
             'JSON' .
             'yes';
 
-        $sHashMD5 = md5($sData.$sKey);
-        $sHashSha2 = hash_hmac('sha384', $sData, $sKey);
-
-        $sHash = ($sFCPOHashMethod == 'sha2-384')
-            ? $sHashSha2 : $sHashMD5;
-
-        return $sHash;
+        return hash_hmac('sha384', $sData, $sKey);
     }
 
     /**
@@ -939,8 +931,6 @@ public function fcpoGetActiveThemePath() {
      */
     public function getHashELVWithChecktype() 
     {
-        $oConfig = $this->_oFcpoHelper->fcpoGetConfig();
-        $sFCPOHashMethod = $oConfig->getConfigParam('sFCPOHashMethod');
         $sKey = $this->getPortalKey();
 
         $sData =
@@ -953,13 +943,7 @@ public function getHashELVWithChecktype()
             'bankaccountcheck' .
             'JSON';
 
-        $sHashMD5 = md5($sData.$sKey);
-        $sHashSha2 = hash_hmac('sha384', $sData, $sKey);
-
-        $sHash = ($sFCPOHashMethod == 'sha2-384')
-            ? $sHashSha2 : $sHashMD5;
-
-        return $sHash;
+        return hash_hmac('sha384', $sData, $sKey);
     }
 
     /**
@@ -969,8 +953,6 @@ public function getHashELVWithChecktype()
      */
     public function getHashELVWithoutChecktype() 
     {
-        $oConfig = $this->_oFcpoHelper->fcpoGetConfig();
-        $sFCPOHashMethod = $oConfig->getConfigParam('sFCPOHashMethod');
         $sKey = $this->getPortalKey();
 
         $sData =
@@ -982,13 +964,7 @@ public function getHashELVWithoutChecktype()
             'bankaccountcheck' .
             'JSON';
 
-        $sHashMD5 = md5($sData.$sKey);
-        $sHashSha2 = hash_hmac('sha384', $sData, $sKey);
-
-        $sHash = ($sFCPOHashMethod == 'sha2-384')
-            ? $sHashSha2 : $sHashMD5;
-
-        return $sHash;
+        return hash_hmac('sha384', $sData, $sKey);
     }
 
     /**

diff --git a/tests/unit/fcPayOne/extend/application/controllers/fcPayonePaymentViewTest.php b/tests/unit/fcPayOne/extend/application/controllers/fcPayonePaymentViewTest.php
@@ -1093,7 +1093,7 @@ public function test_getHashELVWithChecktype_Coverage()
         $oTestObject->expects($this->any())->method('getPortalId')->will($this->returnValue('somePortalId'));
         $oTestObject->expects($this->any())->method('getPortalKey')->will($this->returnValue('somePortalKey'));
 
-        $sExpectHash = md5('someSubaccountIdsomeChecktypesomeEncodingsomeMerchantIdtestsomePortalIdbankaccountcheckJSONsomePortalKey');
+        $sExpectHash = hash_hmac('sha384', 'someSubaccountIdsomeChecktypesomeEncodingsomeMerchantIdtestsomePortalIdbankaccountcheckJSON', 'somePortalKey');
 
         $this->assertEquals($sExpectHash, $this->invokeMethod($oTestObject, 'getHashELVWithChecktype'));
     }
@@ -1131,7 +1131,7 @@ public function test_getHashELVWithoutChecktype_Coverage()
         $oTestObject->expects($this->any())->method('getPortalId')->will($this->returnValue('somePortalId'));
         $oTestObject->expects($this->any())->method('getPortalKey')->will($this->returnValue('somePortalKey'));
 
-        $sExpectHash = md5('someSubaccountIdsomeEncodingsomeMerchantIdtestsomePortalIdbankaccountcheckJSONsomePortalKey');
+        $sExpectHash = hash_hmac('sha384', 'someSubaccountIdsomeEncodingsomeMerchantIdtestsomePortalIdbankaccountcheckJSON', 'somePortalKey');
 
         $this->assertEquals($sExpectHash, $this->invokeMethod($oTestObject, 'getHashELVWithoutChecktype'));
     }