Skip to content

Commit

Permalink
Use proper semver for the installer version
Browse files Browse the repository at this point in the history
  • Loading branch information
F0bes committed Sep 12, 2024
1 parent fdbacc0 commit 882baa5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/create-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,17 @@ jobs:
run: |
"C:\Program Files\7-Zip\7z.exe" x -o.\main pcsx2-${{steps.release_download.outputs.tag_name}}-windows-x64-Qt.7z
- name: Get our version tag
shell: bash
run: |
TAG_NAME=${{ steps.release_download.outputs.tag_name }}
VERSION=${TAG_NAME#v}
echo "VERSION=$VERSION" >> $GITHUB_ENV
- name: Inject Release Tag into Installer Script
shell: bash
run: |
sed -i 's/PCSX2_VERSION_STRING/${{steps.release_download.outputs.tag_name}}/g' 'PCSX2 Installer.iss'
sed -i 's/PCSX2_VERSION_STRING/'"$VERSION"'/g' 'PCSX2 Installer.iss'
- uses: Minionguyjpro/[email protected]
name: Build the Release
Expand Down
4 changes: 2 additions & 2 deletions PCSX2 Installer.iss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#define MyAppName "PCSX2"

; Automatically changed by the GitHub action. An example would be "v2.0.0"
; Automatically changed by the GitHub action. An example would be "2.0.0"
#define MyAppVersion "PCSX2_VERSION_STRING"
#define MyAppPublisher "PCSX2 Team"
#define MyAppURL "https:/pcsx2.net/"
Expand Down Expand Up @@ -35,7 +35,7 @@ DefaultGroupName={#MyAppName}
DefaultDirName={commonpf64}\{#MyAppName}

OutputDir=PCSX2
OutputBaseFilename={#MyAppName}-{#MyAppVersion}-windows-x64-installer
OutputBaseFilename={#MyAppName}-v{#MyAppVersion}-windows-x64-installer

; InfoAfterFile=README.txt
UninstallDisplayIcon={app}\{#MyAppExeName},0
Expand Down

0 comments on commit 882baa5

Please sign in to comment.