Skip to content

Include nlohmann before PDAL. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
dependencies:
- scikit-build-core
- numpy
- pdal
- libpdal-core
- compilers
- python
- pip
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,13 @@ jobs:
fail-fast: true
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
python-version: ['3.9', '3.10', '3.11', '3.12']
numpy-version: ['1.26', '2.0', '2.1']
python-version: ['3.10', '3.11', '3.12', '3.13']
numpy-version: ['1.24', '2.1']
exclude:
- python-version: 3.9
numpy-version: 2.1
- python-version: '3.12'
numpy-version: '1.24'
- python-version: '3.13'
numpy-version: '1.24'

steps:
- name: Check out
Expand All @@ -37,7 +39,7 @@ jobs:
- name: Setup micromamba
uses: conda-incubator/setup-miniconda@v3
with:
miniforge-variant: Mambaforge
miniforge-variant: Miniforge3
miniforge-version: latest
use-mamba: true
python-version: ${{ matrix.python-version }}
Expand Down
4 changes: 2 additions & 2 deletions src/pdal/filters/PythonFilter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
* OF SUCH DAMAGE.
****************************************************************************/

#include "PythonFilter.hpp"

#include "../nlohmann/json.hpp"

#include "PythonFilter.hpp"

#include <pdal/PointView.hpp>
#include <pdal/DimUtil.hpp>
#include <pdal/util/ProgramArgs.hpp>
Expand Down
21 changes: 21 additions & 0 deletions src/pdal/filters/export.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#pragma once


#ifdef _WIN32
# define PDAL_EXPORT __declspec(dllexport)
# define PDAL_LOCAL
# define PDAL_EXPORT_UNIX
#ifdef __GNUC__
# define PDAL_EXPORT_DEPRECATED __attribute__((deprecated)) PDAL_EXPORT
#else
# define PDAL_EXPORT_DEPRECATED __declspec(deprecated, dllexport)
#endif
#else
# define PDAL_EXPORT __attribute__ ((visibility("default")))
// Keep the PDAL_DLL name around so any external plugins that still might have that defined
// can still compile and be used
# define PDAL_DLL PDAL_EXPORT
# define PDAL_LOCAL __attribute__((visibility("hidden")))
# define PDAL_EXPORT_UNIX __attribute__ ((visibility("default")))
# define PDAL_EXPORT_DEPRECATED __attribute__((deprecated))
#endif // _WIN32
2 changes: 2 additions & 0 deletions src/pdal/test/NumpyReaderTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@

#include <pdal/pdal_test_main.hpp>

#include "../filters/export.hpp"

#include <pdal/PipelineManager.hpp>
#include <pdal/StageFactory.hpp>
#include <pdal/filters/StatsFilter.hpp>
Expand Down
2 changes: 2 additions & 0 deletions src/pdal/test/PythonFilterTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@

#include <pdal/pdal_test_main.hpp>

#include "../filters/export.hpp"

#include <pdal/PipelineManager.hpp>
#include <pdal/StageFactory.hpp>
#include <pdal/io/FauxReader.hpp>
Expand Down
Loading