fix: array declaration sniff #1104
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds two changes to array declaration sniff:
DoubleArrowNotAligned
is triggered - currently with continue it simply doesn't fix array values as expected - it keeps whitespaces for it in case double arrow is not aligned as expectedalignDoubleArrowToLongestIndex
property toArrayDeclarationSniff
, with true value by defualt, when changed to false phpcs will align double arrow to length of index of elementBasically for example now when running phpcs for such array:
With
alignDoubleArrowToLongestIndex
value astrue
will produce output:With
alignDoubleArrowToLongestIndex
value asfalse
will produce output:Suggested changelog entry
alignDoubleArrowToLongestIndex
toSquiz.Arrays.ArrayDeclaration
to allow double arrow alignment without keeping double arrow on same position of all elementsSquiz.Arrays.ArrayDeclaration.ValueNotAligned
not being reported whenSquiz.Arrays.ArrayDeclaration.DoubleArrowNotAligned
was reported for same array elementTypes of changes
PR checklist