PHP 8.4 | Tokenizer/PHP: allow for anon class dereferencing #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.4, new expressions can be dereferenced without needing parentheses wrappers, as long as they have the parentheses for the constructor arguments.
```php
echo new MyClass()->property;
echo new $myClass(['value'])[0];
```
Additionally, new expressions involving anonymous classes can also be dereferenced directly and these do not have the constructor argument parentheses requirement.
```php
echo new class { public $property = 'property'; }->property;
echo new class (['value']) extends ArrayObject {}[0];
```
For the most part, this has no impact on the PHPCS tokenizer layer, however, dereferencing the result of a new anonymous class expression using array access runs into trouble with the short array retokenization.
I.e. the square brackets in the below example were tokenized as `T_OPEN|CLOSE_SHORT_ARRAY`, while they should be tokenized as `T_OPEN|CLOSE_SQUARE_BRACKET`.
```php
echo new class {}[0];
```
Fixed now. Includes tests safeguarding the fix.
Refs:
* https://wiki.php.net/rfc/new_without_parentheses
* php/php-src 13029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of PHP 8.4, new expressions can be dereferenced without needing parentheses wrappers, as long as they have the parentheses for the constructor arguments.
Additionally, new expressions involving anonymous classes can also be dereferenced directly and these do not have the constructor argument parentheses requirement.
For the most part, this has no impact on the PHPCS tokenizer layer, however, dereferencing the result of a new anonymous class expression using array access runs into trouble with the short array retokenization. I.e. the square brackets in the below example were tokenized as
T_OPEN|CLOSE_SHORT_ARRAY, while they should be tokenized asT_OPEN|CLOSE_SQUARE_BRACKET.Fixed now. Includes tests safeguarding the fix.
Refs:
Suggested changelog entry
Fixed: the square brackets for array access on a new anonymous class expression without wrapping parentheses, as allowed since PHP 8.4, were tokenized as short array tokens instead of square bracket tokens.
Related issues/external references
Related to #734