[4.0] Fix exit code when phpcbf is processing STDIN

[fredden]

Description

When running phpcbf with a PHP file as input (eg, phpcbf < test.php), the exit code was not reported correctly. This pull request fixes that bug. For more details, see #1082.

Suggested changelog entry

Fixed exit code when phpcbf is processing STDIN

Related issues/external references

Fixes #1082

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have added tests to cover my changes.
• I have verified that the code complies with the projects coding standards.
• [Required for new sniffs] I have added XML documentation for the sniff.
• I have opened a sister-PR in the documentation repository to update the Wiki.

[fredden]

@jrfnl how would you like to cover this change with tests?

[jrfnl]

how would you like to cover this change with tests?

I imagine it may be difficult to cover this change via the PHPUnit setup as it would require mocking STDIN. How about adding some tests to the bashunit E2E testsuite ?

[jrfnl]

@fredden Just checking - will you have time over the next few days to add a few bashunit tests for STDIN handling ? Or would you like me to add something ?

[fredden]

I'm happy to update this, but I'm away at the moment. Earliest that I can pick this up again would be Wednesday/Thursday this week. I do have a bash script that I used for local development which will be trivial to convert into the format needed for bashunit.

If you want to land this before Friday, feel free to add some tests.

[jrfnl]

@fredden Thanks for adding the tests! I've had a play with this and left some feedback inline. Not necessarily blocking. We could decide to merge this now and iterate on organizing the bashunit tests in a future PR.

[jrfnl]

@fredden Thank you for working on this and the updates! Glad that this will be sorted before the release. 👍🏻