Skip to content

Commit

Permalink
Merge PIVX-Project#2787: [GA] Update depreciated actions
Browse files Browse the repository at this point in the history 
0fee41c [CMake] Use proper language launcher define (Fuzzbawls)
c64a766 [GA] Use shorter ccache file names for wallet builds (Fuzzbawls)
c9ea6c7 [GA] Use environment files instead of deprecated set-output (Fuzzbawls)
0ee6397 [GA] update to cache v3 (Fuzzbawls)
90ffa45 [GA] update to setup-python v4 (Fuzzbawls)
1794daa [GA] Update to checkout v3 (Fuzzbawls)

Pull request description:

  Node 12 actions have been depreciated. Update actions to use Node 16 based versions.
  Ref: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

  `save-state` and `set-output` have been depreciated. Update GA workflow to no longer use these functions.
  Ref: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

  Use shorter ccache cache identifiers

  Use explicit CMAKE language launcher variable names

ACKs for top commit:
  Liquid369:
    utACK 0fee41c
  panleone:
    uTACK 0fee41c

Tree-SHA512: 088232d292a4ef7e80353e4e8b9c6c0dba2a17b361376e199eb55f0f67d3e29e195babf3c89a3ee58407f44263832dba16d56c6aa888ea4e179655e832cefbad
  • Loading branch information
@Fuzzbawls
Fuzzbawls committed Feb 8, 2023
2 parents 3c63095 + 0fee41c commit 286c318
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 25 deletions.
45 changes: 22 additions & 23 deletions .github/workflows/build-and-test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ jobs:
shell: bash
steps:
- name: Checkout Repo
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Initialize Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.6

Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:

steps:
- name: Get Source
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Environment
run: |
Expand All @@ -102,13 +102,10 @@ jobs:
- name: Prepare ccache timestamp
id: ccache_cache_timestamp
shell: cmake -P {0}
run: |
string(TIMESTAMP current_date "%Y-%m-%d-%H;%M;%S" UTC)
message("::set-output name=timestamp::${current_date}")
run: echo "timestamp=$(date +%Y-%m-%dT%H:%M:%S%z)" >> $GITHUB_OUTPUT

- name: ccache cache files
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: .ccache
key: cmake-${{ matrix.config.name }}-ccache-${{ steps.ccache_cache_timestamp.outputs.timestamp }}
Expand Down Expand Up @@ -178,7 +175,7 @@ jobs:

steps:
- name: Get Source
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Environment
run: |
Expand All @@ -187,13 +184,10 @@ jobs:
- name: Prepare Depends timestamp
id: depends_cache_timestamp
shell: cmake -P {0}
run: |
string(TIMESTAMP current_date "%Y-%m-%d-%H;%M;%S" UTC)
message("::set-output name=timestamp::${current_date}")
run: echo "timestamp=$(date +%Y-%m-%dT%H:%M:%S%z)" >> $GITHUB_OUTPUT

- name: depends cache files
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: |
depends/built
Expand Down Expand Up @@ -254,6 +248,7 @@ jobs:
matrix:
config:
- name: ARM 32-bit [GOAL:install] [no unit or functional tests]
id: ARM32
os: ubuntu-18.04
host: arm-linux-gnueabihf
apt_get: python3 g++-arm-linux-gnueabihf
Expand All @@ -265,6 +260,7 @@ jobs:
BITCOIN_CONFIG: "--with-gui=qt5 --enable-glibc-back-compat --enable-reduce-exports --disable-online-rust CXXFLAGS=-Wno-psabi"

- name: AARCH64 [GOAL:install] [no unit or functional tests]
id: ARM64
os: ubuntu-18.04
host: aarch64-linux-gnu
apt_get: python3 g++-aarch64-linux-gnu
Expand All @@ -274,6 +270,7 @@ jobs:
BITCOIN_CONFIG: "--with-gui=qt5 --enable-glibc-back-compat --enable-reduce-exports --disable-online-rust"

- name: Win64 [GOAL:deploy] [no unit or functional tests]
id: Win64
os: ubuntu-18.04
host: x86_64-w64-mingw32
apt_get: python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64
Expand All @@ -283,6 +280,7 @@ jobs:
BITCOIN_CONFIG: "--with-gui=auto --enable-reduce-exports --disable-online-rust"

- name: x86_64 Linux [GOAL:install] [bionic]
id: Linux-x86_64
os: ubuntu-18.04
host: x86_64-unknown-linux-gnu
apt_get: python3-zmq qtbase5-dev qttools5-dev-tools libqt5svg5-dev libqt5charts5-dev libqrencode-dev libdbus-1-dev libharfbuzz-dev
Expand All @@ -293,6 +291,7 @@ jobs:
BITCOIN_CONFIG: "--enable-zmq --with-gui=qt5 --enable-glibc-back-compat --enable-reduce-exports --disable-online-rust"

- name: x86_64 Linux [GOAL:install] [bionic] [no GUI no unit tests - only functional tests on legacy pre-HD wallets]
id: Linux-x86_64-nogui
os: ubuntu-18.04
host: x86_64-unknown-linux-gnu
apt_get: python3-zmq
Expand All @@ -303,6 +302,7 @@ jobs:
BITCOIN_CONFIG: "--enable-zmq --with-gui=no --enable-glibc-back-compat --enable-reduce-exports --disable-online-rust"

- name: x86_64 Linux [GOAL:install] [bionic] [no depends only system libs]
id: Linux-x86_64-nodepends
os: ubuntu-18.04
host: x86_64-unknown-linux-gnu
apt_get: python3-zmq qtbase5-dev qttools5-dev-tools libqt5svg5-dev libqt5charts5-dev libevent-dev bsdmainutils libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev libdb5.3++-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev libqrencode-dev libgmp-dev libsodium-dev cargo
Expand All @@ -312,6 +312,7 @@ jobs:
BITCOIN_CONFIG: "--enable-zmq --with-incompatible-bdb --with-gui=qt5 CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER'"

- name: macOS 10.12 [GOAL:deploy] [no functional tests]
id: macOS10.12
os: ubuntu-18.04
host: x86_64-apple-darwin16
apt_get: cmake imagemagick libcap-dev librsvg2-bin libz-dev libbz2-dev libtiff-tools python3-dev python3-setuptools
Expand All @@ -323,6 +324,7 @@ jobs:
BITCOIN_CONFIG: "--enable-gui --enable-reduce-exports --enable-werror --disable-online-rust"

- name: macOS 11 [GOAL:deploy] [native macOS using syslibs]
id: macOS11
os: macos-11
host: x86_64-apple-darwin20.6.0
brew_install: autoconf automake ccache berkeley-db4 libtool boost miniupnpc pkg-config [email protected] qt5 zmq libevent qrencode gmp libsodium rust librsvg
Expand All @@ -336,7 +338,7 @@ jobs:

steps:
- name: Get Source
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Environment
run: |
Expand All @@ -352,7 +354,7 @@ jobs:
- name: depends cache files
if: matrix.config.no_depends != 1
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: |
depends/built
Expand All @@ -364,20 +366,17 @@ jobs:
- name: Prepare ccache timestamp
id: ccache_cache_timestamp
shell: cmake -P {0}
run: |
string(TIMESTAMP current_date "%Y-%m-%d-%H;%M;%S" UTC)
message("::set-output name=timestamp::${current_date}")
run: echo "timestamp=$(date +%Y-%m-%dT%H:%M:%S%z)" >> $GITHUB_OUTPUT

- name: ccache cache files
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: |
.ccache
.pivx-params
key: ${{ matrix.config.name }}-ccache-${{ steps.ccache_cache_timestamp.outputs.timestamp }}
key: ${{ matrix.config.id }}-ccache-${{ steps.ccache_cache_timestamp.outputs.timestamp }}
restore-keys: |
${{ matrix.config.name }}-ccache-
${{ matrix.config.id }}-ccache-
- name: Build Wallet
run: |
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ if(CCACHE_PROGRAM)
message(STATUS "Found ccache: ${CCACHE_PROGRAM}")
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CCACHE_PROGRAM}")
# Set up wrapper scripts
set(C_LAUNCHER "${CCACHE_PROGRAM}")
set(CXX_LAUNCHER "${CCACHE_PROGRAM}")
set(CMAKE_C_COMPILER_LAUNCHER "${CCACHE_PROGRAM}")
set(CMAKE_CXX_COMPILER_LAUNCHER "${CCACHE_PROGRAM}")
endif()

# Search for the cargo and rustc compilers required to build libzcashrust
Expand Down

0 comments on commit 286c318

Please sign in to comment.