Also use pointers for components

PRODYNA · May 13, 2024 · a3866ce · a3866ce
1 parent 7283458
commit a3866ce
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/changelog/generate.go b/changelog/generate.go
@@ -40,7 +40,7 @@ func (clg *ChangelogGenerator) Generate(ctx context.Context) (changelog *output.
 		Releases: &[]output.Release{
 			{
 				Tag:        "0.0.0",
-				Components: []output.Component{},
+				Components: &[]output.Component{},
 			},
 		},
 	}

diff --git a/changelog/output/format.go b/changelog/output/format.go
@@ -18,8 +18,8 @@ type Component struct {
 }
 
 type Release struct {
-	Tag        string      `json:"tag"`
-	Components []Component `json:"components"`
+	Tag        string       `json:"tag"`
+	Components *[]Component `json:"components"`
 }
 
 type Changelog struct {
@@ -36,7 +36,7 @@ func (c *Changelog) AddEntry(entry Entry) {
 		// no releaes, create it anyways
 		*c.Releases = append(*c.Releases, Release{
 			Tag:        entry.Tag,
-			Components: []Component{}})
+			Components: &[]Component{}})
 	} else {
 		// find the right place to insert the release
 		for _, r := range *c.Releases {
@@ -50,7 +50,7 @@ func (c *Changelog) AddEntry(entry Entry) {
 				// add release before the current release
 				*c.Releases = append(*c.Releases, Release{
 					Tag:        entry.Tag,
-					Components: []Component{}})
+					Components: &[]Component{}})
 			}
 			break
 		}
@@ -59,7 +59,7 @@ func (c *Changelog) AddEntry(entry Entry) {
 	// find the right release and add the component
 	for i, release := range *c.Releases {
 		if release.Tag == entry.Tag {
-			(*c.Releases)[i].Components = append((*c.Releases)[i].Components, Component{
+			*(*c.Releases)[i].Components = append(*(*c.Releases)[i].Components, Component{
 				Name:        entry.Component,
 				Description: entry.Description,
 			})

diff --git a/changelog/output/format_test.go b/changelog/output/format_test.go
@@ -50,16 +50,16 @@ func TestChangelog_AddEntry(t *testing.T) {
 		t.Errorf("expected 3 releases, got %d", len(*changelog.Releases))
 	}
 
-	if len((*changelog.Releases)[0].Components) != 1 {
-		t.Errorf("expected 2 components, got %d", len((*changelog.Releases)[0].Components))
+	if len(*(*changelog.Releases)[0].Components) != 1 {
+		t.Errorf("expected 2 components, got %d", len(*(*changelog.Releases)[0].Components))
 	}
 
-	if len((*changelog.Releases)[1].Components) != 2 {
-		t.Errorf("expected 2 components, got %d", len((*changelog.Releases)[1].Components))
+	if len(*(*changelog.Releases)[1].Components) != 2 {
+		t.Errorf("expected 2 components, got %d", len(*(*changelog.Releases)[1].Components))
 	}
 
-	if len((*changelog.Releases)[2].Components) != 2 {
-		t.Errorf("expected 1 component, got %d", len((*changelog.Releases)[2].Components))
+	if len(*(*changelog.Releases)[2].Components) != 2 {
+		t.Errorf("expected 1 component, got %d", len(*(*changelog.Releases)[2].Components))
 	}
 
 	// expect that the first release is 1.2.0