Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgix should ignore files in data, config, and assets folders #35

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

cassiancc
Copy link
Contributor

This aims to fix #30 and #33 by having Forgix ignore files in data, assets, and config directories. Open to feedback of course, but some resolution is necessary as without a fix like this one mods that provide worldgen files like Infinite Dimensions are unusable with Forgix, as it detects the data key as if it was a mixin.

@cassiancc
Copy link
Contributor Author

cassiancc commented Oct 26, 2024

An example file in the config folder that caused Forgix to detect it as a mixin.

{
	"feature": "infinity:all_trees",
	"placement": [
		{
			"count": {
				"type": "minecraft:weighted_list",
				"distribution": [
					{
						"data": 6,
						"weight": 9
					},
					{
						"data": 7,
						"weight": 1
					}
				]
			},
			"type": "minecraft:count"
		},
		{
			"type": "minecraft:in_square"
		},
		{
			"type": "minecraft:surface_water_depth_filter",
			"max_water_depth": 0
		},
		{
			"heightmap": "OCEAN_FLOOR",
			"type": "minecraft:heightmap"
		},
		{
			"type": "minecraft:biome"
		}
	]
}

@Ran-Mewo Ran-Mewo merged commit e8d0bde into PacifistMC:main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forgix changing JSON files inside data directory?
2 participants