Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deleting multiple custom registries #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Dec 8, 2024

Issue

close #215

Result

20241210-161621.mp4

Copy link

changeset-bot bot commented Dec 8, 2024

⚠️ No Changeset found

Latest commit: df2c456

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chouchouji chouchouji force-pushed the feat-delete-multiple-registry branch from 99b7bc3 to df2c456 Compare December 10, 2024 08:11
@chouchouji
Copy link
Contributor Author

@iosh I have implemented the need, Please add test cases in this pr. Thanks.

@iosh
Copy link
Collaborator

iosh commented Dec 10, 2024

Sorry, I will review it as soon as possible (been a bit busy lately).

@iosh
Copy link
Collaborator

iosh commented Dec 10, 2024

@iosh I have implemented the need, Please add test cases in this pr. Thanks.

OK, but not sure if it can be completed this week.

@chouchouji
Copy link
Contributor Author

Sorry, I will review it as soon as possible (been a bit busy lately).

Thanks.

@chouchouji
Copy link
Contributor Author

@iosh I have implemented the need, Please add test cases in this pr. Thanks.

OK, but not sure if it can be completed this week.

I think this task is not urgent. We can complete it when you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support deleting multiple custom registries
2 participants