Further improvements on the build environment #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A newline was missing on the instalation. First the installer creates a /usr/include/FreeImage directory and then copies the header files to that directory. Instead of that, the two commands were merged into a single line for some reason. That's now fixed.
Simply downloads the 2.3.0 release from github.
The requests python package was missing so downloading the assets and libraries did not work.
|
Thank you! 😄 |
The generate_gmake2_vulkan.py script needs this binary in order to unzip the necessary assets and libraries.
As an optimization, the script does not download and extract third party libraries, as those are already included on the build environment.
The build script checks for the spartan.sln even on linux, which prints a false error telling that the project was not generated succesfully. This now checks for the makefiles instead for the visual studio solution on linux.
|
Ready for review! Once this is in I'll start working on bringing FSR2 and LinearMath as the last two dependencies for the project (fmod for another time :P). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further advances the build environment used for building the spartan engine for linux. This PR does the next things:
7zabinary for use in the project generationThis PR further advances on the #66 issue.