Make GameRule a FeatureDependant #12429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have a system for that around FeatureDependant and FeatureFlagSetHolder. |
|
That doesn't seem to be the case. |
|
Yea it doesn't rn xD SOrry I wasnt clear, the PR should do that instead of adding a new system. |
|
Okay, I'll do that then 👍 |
DerEchtePilz
force-pushed
the
gamerule-accessiblity
branch
from
d67e869 to
dffa034
Compare
DerEchtePilz
changed the title
lynxplay
approved these changes
Apr 13, 2025
There was a problem hiding this comment.
Generally LGTM!
I do wonder however if it would be smart to patch the GameRules internals to also maintain a Map<String, GameRule.Type<?>> for faster access.
The fact that this method is going to be pretty spam-heavy for checks would mean such optimisations would have a hopefully measurable effect.
github-project-automation
bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
lynxplay
reviewed
Apr 13, 2025
paper-server/patches/sources/net/minecraft/world/level/GameRules.java.patch
Outdated
Show resolved
Hide resolved
masmc05
reviewed
Apr 13, 2025
paper-server/patches/sources/net/minecraft/world/level/GameRules.java.patch
Show resolved
Hide resolved
paper-server/patches/sources/net/minecraft/world/level/GameRules.java.patch
Outdated
Show resolved
Hide resolved
lynxplay
force-pushed
the
gamerule-accessiblity
branch
from
584a7c1 to
ab35a42
Compare
github-project-automation
bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was playing around with game rules a bit and after running into an issue that
GameRule#values()does contain even game rules that are disabled because the experimental data pack isn't enabled, I was wondering if there was a way to check if a game rule is enabled or not.What I've found is that
World#getGameRules()should contain only enabled game rules, however that wasn't applicable for my usecase since I didn't have a world available.This PR adds an
isEnabled()method to theGameRuleclass to make it possible to check if the game rule is enabled without needing access to a world.