Update Obsolete.Fody and remove workaround

Particular · Feb 7, 2025 · 8494cf4 · 8494cf4
1 parent 023ee72
commit 8494cf4
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 13 deletions.
diff --git a/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/FeatureFlag.cs b/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/FeatureFlag.cs
@@ -6,9 +6,6 @@ namespace NServiceBus.Transport.RabbitMQ.ManagementApi;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-// This is to prevent Fody throwing an error on classes with `required` properties (since the compiler marks the default constructor with an `[Obsolete]` attribute)
-// https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-11.0/required-members#metadata-representation
-[method: DoNotWarnAboutObsoleteUsage]
 class FeatureFlag()
 {
     [JsonRequired]

diff --git a/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/Overview.cs b/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/Overview.cs
@@ -7,9 +7,6 @@ namespace NServiceBus.Transport.RabbitMQ.ManagementApi;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-// This is to prevent Fody throwing an error on classes with `required` properties (since the compiler marks the default constructor with an `[Obsolete]` attribute)
-// https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-11.0/required-members#metadata-representation
-[method: DoNotWarnAboutObsoleteUsage]
 class Overview()
 {
     [JsonPropertyName("product_name")]

diff --git a/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/Policy.cs b/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/Policy.cs
@@ -6,9 +6,6 @@ namespace NServiceBus.Transport.RabbitMQ.ManagementApi;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-// This is to prevent Fody throwing an error on classes with `required` properties (since the compiler marks the default constructor with an `[Obsolete]` attribute)
-// https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-11.0/required-members#metadata-representation
-[method: DoNotWarnAboutObsoleteUsage]
 class Policy()
 {
     [JsonPropertyName("vhost")]

diff --git a/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/Queue.cs b/src/NServiceBus.Transport.RabbitMQ/Administration/ManagementApi/Models/Queue.cs
@@ -6,9 +6,6 @@ namespace NServiceBus.Transport.RabbitMQ.ManagementApi;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-// This is to prevent Fody throwing an error on classes with `required` properties (since the compiler marks the default constructor with an `[Obsolete]` attribute)
-// https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-11.0/required-members#metadata-representation
-[method: DoNotWarnAboutObsoleteUsage]
 class Queue()
 {
     [JsonRequired]

diff --git a/src/NServiceBus.Transport.RabbitMQ/NServiceBus.Transport.RabbitMQ.csproj b/src/NServiceBus.Transport.RabbitMQ/NServiceBus.Transport.RabbitMQ.csproj
@@ -16,7 +16,7 @@
 
   <ItemGroup>
     <PackageReference Include="Fody" Version="6.9.1" PrivateAssets="All" />
-    <PackageReference Include="Obsolete.Fody" Version="5.3.0" PrivateAssets="All" />
+    <PackageReference Include="Obsolete.Fody" Version="5.3.1" PrivateAssets="All" />
     <PackageReference Include="Particular.Packaging" Version="4.2.0" PrivateAssets="All" />
   </ItemGroup>